Add Persistent search control + PersistentSearch() #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: search.go
Conflicts: control.go
Fix control round-tripping, parsing
…sistent-search Conflicts: control.go
|
Any update on this PR? |
|
@christian-roggia I can rework this after #160 and maybe #172 have been merged. I would need you to test it after reworking it. |
|
@vetinari As soon as this PR will be merged I will open a new PR with the Persistent Search for Microsoft Active Directory, which is slightly different. My implementation is not perfect and could use some improvements but it is stable and we are using it in our stage environment and soon will be deployed to production. Please let me know if there is a channel (Slack, Skype, Hangouts) where we can coordinate efforts for this PR. |
|
@vetinari - do you want to clean this up for merging? |
|
@vetinari another one to update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the persistent search control from https://www.ietf.org/proceedings/50/I-D/ldapext-psearch-03.txt. The code comes with a PersistentSearch() function to use this control.
minor change: use the LDAP Application Codes (e.g. ApplicationSearchResultEntry) instead of the int in the result parsing.