fix panic in addControlDescriptions() #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply similar patch like in go-ldap#83, closes go-ldap#86
| @@ -153,15 +153,37 @@ func addLDAPDescriptions(packet *ber.Packet) (err error) { | |||
| func addControlDescriptions(packet *ber.Packet) { | |||
| packet.Description = "Controls" | |||
| for _, child := range packet.Children { | |||
| var value *ber.Packet | |||
There was a problem hiding this comment.
can we do the same thing here where we declare controlType := "", set it inside the cases, then switch on controlType instead of child.Children[0].Value.(string)?
|
probably worth adding a similar unit test to make sure addControlDescriptions() works when called with packets off the wire |
|
looks good, just a couple comments. thanks! |
|
done, found a bug with the tests ;-) |
|
LGTM, needs a rebase (and squash while you're at it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply similar patch like in #83, closes #86