use golangci-lint-action #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
force-pushed
the
linter
branch
3 times, most recently
from
4e56ae4 to
ceaf8c6
Compare
|
@thockin: I've kept the one commit which intentionally introduces a linter violation to demonstrate how the annotations look like. Will remove before we merge. |
pohly
commented
Aug 20, 2021
pohly
commented
Aug 20, 2021
The integration with GitHub is better. It uses caching and posts errors as annotations to the PR. This is easier to use than having to dig into the log to find errors.
pohly
commented
Aug 20, 2021
funcr/funcr.go
Outdated
| @@ -67,7 +67,7 @@ type Options struct { | |||
| // This has some overhead, so some users might not want it. | |||
| LogCaller MessageClass | |||
|
|
|||
| // LogTimestamp tells funcr to add a "ts" key to log lines. This has some | |||
| // LogTimestamps tells funcr to add a "ts" key to log lines. This has some | |||
There was a problem hiding this comment.
It's perhaps worth pointing out that this intentional revert to a typo is not flagged as an issue. My theory is that slight grammatical changes like appending "s" are not seen as a problem by the "revive" check.
There was a problem hiding this comment.
indeed. It catches that same error on a public method. We should file a bug against revive :)
golangci-lint by default suppresses issues about invalid comments. This let some real errors (cut-and-paste, incomplete rename) slip through. Fixes: go-logr#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration with GitHub is better. It uses caching and posts
errors as annotations to the PR. This is easier to use than having to
dig into the log to find errors.
Fixes #82