This fixes issue #34. Using the wrong hostname. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When registering as a slave we are using the wrong hostname. It should be our hostname, not the hostname name of the server we are connecting to.
| @@ -62,6 +65,15 @@ func NewBinlogSyncer(serverID uint32, flavor string) *BinlogSyncer { | |||
| return b | |||
| } | |||
|
|
|||
| func (b *BinlogSyncer) LocalHostname() string { | |||
|
|
|||
| if b.MyHost == "" { | |||
There was a problem hiding this comment.
Sorry, that should have been LocalHost, not MyHost. I started with MyHost, then change my mind on the name. I just missed this when I redid the changes on my local computer. I'm surprised that the compiler did not catch this?
|
Hi @gdey , I guess if we don't register slave, we can still sync binlog from mysql master. |
|
I'm going to close this and reopen it. Goofed in my repo. And started committing to master, instead of a feature branch. I'm not sure what you are asking with the second comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering as a slave we are using the wrong hostname. It should
be our hostname, not the hostname name of the server we are connecting
to.