refine usage of MaxReconnectAttempts in BinlogSyncer #417
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @siddontang @GregoryIan @csuzhangxc |
amyangfei
force-pushed
the
refine-sync-retry-strategy
branch
from
a73b98a to
eba6a01
Compare
|
LGTM. we need this |
siddontang
reviewed
Sep 2, 2019
| MaxReconnectAttempts int | ||
|
|
||
| // whether disable re-sync for broken connection | ||
| DisableRetrySync bool |
There was a problem hiding this comment.
setting MaxReconnectAttempts = 0 is not enough?
There was a problem hiding this comment.
I prefer changing the way of MaxReconnectAttempts
There was a problem hiding this comment.
then what about
- MaxReconnectAttempts < 0, no retry
- MaxReconnectAttempts = 0, infinite retry
- MaxReconnectAttempts > 0, retry for MaxReconnectAttempts time
There was a problem hiding this comment.
ok, for < 0, we can change the value to MaxInt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine binlog synchronization retry strategy, make it possible for user to disable retry sync or retry forever.
After this pr the default retry strategy for BinlogSyncer is no retry (ifMaxReconnectAttemptsis not configurated and use default value zero)DisableRetrySyncoption, the default behavior for retry strategy is not changed, and user also can disable retry by settingDisableRetrySyncto true