Skip to content

Add MysqlGTIDSet.Add() and Minus() methods #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

ostinru
Copy link

@ostinru ostinru commented Jan 10, 2022

Add MysqlGTIDSet.Add() and Minus() methods, so it will help users to estimate GTID sets that are stored in binlog file.

…estimate GTID sets that are stored in binlog.
Copy link
Member

@atercattus atercattus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But fix the tests and lint, please.

@ostinru
Copy link
Author

ostinru commented Jan 11, 2022

@atercattus, could you please trigger github workflow checks for this PR?
I have no permissions for doing this.

@atercattus
Copy link
Member

Sorry, I forgot about this 🙂

@ostinru
Copy link
Author

ostinru commented Jan 12, 2022

Hi, @atercattus it seems that this PR is ready to be merged. Could you please merge it?

@lance6716 lance6716 merged commit b3f1a27 into go-mysql-org:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants