Add support for custom dialer in canal and binlog syncer #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viciious
force-pushed
the
canal_dialer
branch
7 times, most recently
from
8883176 to
c8e0826
Compare
|
OK, this is now ready for review |
lance6716
approved these changes
Jun 28, 2022
|
Hi, kindly remind that you may encounter this issue |
Oh, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow custom dialers in canal in binlog syncer. This change introduces some minor copy&paste code mainly in order to set the timeout context at 10 seconds to mimic the behavior of client.Connect