Added SetTableCache method to set new schema for a table without load… #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it from the source database.
|
@lance6716 this PR is minimal and straight forward I think. Also it is a bit of a blocker for us, of course unless we use a fork. Thanks for looking at it! |
lance6716
approved these changes
Jul 19, 2022
canal/canal.go
Outdated
| @@ -380,6 +380,18 @@ func (c *Canal) ClearTableCache(db []byte, table []byte) { | |||
| c.tableLock.Unlock() | |||
| } | |||
|
|
|||
| // SetTableCache sets table cache value for the given key | |||
There was a problem hiding this comment.
"for the given key" maybe not as straightforward as "for the given table"
There was a problem hiding this comment.
Changed it to be "for the given table". Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Canal lacks ability to set table schema cache bypassing the schema reload from the replicated source database. This makes it impossible to replay the binlog with several table schema changes in the sequence even when you have history of table schemas for every change at your hand.
Solution
This PR adds SetTableCache method for canal users to be able to directly set table schema whenever a user sees fit, for example, when detecting schema change (through a table rename statement e.x. RENAME _temp_migration_123 to my_table) while replaying binlog history.