Skip to content

support to check if a column is primary key #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 29, 2022
Merged

support to check if a column is primary key #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b62ff79
support to get Index by column index
fungaren Nov 26, 2022
cd825ce
fix typo
fungaren Nov 26, 2022
647bbee
rename to GetPKIndex
fungaren Nov 28, 2022
6d722ea
add unit test
fungaren Nov 28, 2022
36d88b9
IsPrimaryKey
fungaren Nov 28, 2022
1f54d98
code style
fungaren Nov 28, 2022
7d5efc5
Merge branch 'master' into get-idx-by-col-idx
lance6716 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions schema/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,23 @@ func (ta *Table) FindColumn(name string) int {
return -1
}

// Get TableColumn by column index of primary key.
func (ta *Table) GetPKColumn(index int) *TableColumn {
if index >= len(ta.PKColumns) {
return nil
}
return &ta.Columns[ta.PKColumns[index]]
}

func (ta *Table) IsPrimaryKey(colIndex int) bool {
for _, i := range ta.PKColumns {
if i == colIndex {
return true
}
}
return false
}

func (ta *Table) AddIndex(name string) (index *Index) {
index = NewIndex(name)
ta.Indexes = append(ta.Indexes, index)
Expand Down Expand Up @@ -413,6 +426,7 @@ func (ta *Table) fetchPrimaryKeyColumns() error {
return nil
}

// Primary key must be the first index?
pkIndex := ta.Indexes[0]
if pkIndex.Name != "PRIMARY" {
return nil
Expand Down
20 changes: 15 additions & 5 deletions schema/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import (

// use docker mysql for test
var host = flag.String("host", "127.0.0.1", "MySQL host")
var schema = flag.String("schema", "test", "MySQL Database")
var pwd = flag.String("pwd", "", "MySQL password")

func Test(t *testing.T) {
TestingT(t)
Expand All @@ -28,10 +30,10 @@ var _ = Suite(&schemaTestSuite{})

func (s *schemaTestSuite) SetUpSuite(c *C) {
var err error
s.conn, err = client.Connect(fmt.Sprintf("%s:%d", *host, 3306), "root", "", "test")
s.conn, err = client.Connect(fmt.Sprintf("%s:%d", *host, 3306), "root", *pwd, *schema)
c.Assert(err, IsNil)

s.sqlDB, err = sql.Open("mysql", fmt.Sprintf("root:@%s:3306", *host))
s.sqlDB, err = sql.Open("mysql", fmt.Sprintf("root:%s@%s:3306", *pwd, *host))
c.Assert(err, IsNil)
}

Expand Down Expand Up @@ -75,12 +77,20 @@ func (s *schemaTestSuite) TestSchema(c *C) {
_, err = s.conn.Execute(str)
c.Assert(err, IsNil)

ta, err := NewTable(s.conn, "test", "schema_test")
ta, err := NewTable(s.conn, *schema, "schema_test")
c.Assert(err, IsNil)

c.Assert(ta.Columns, HasLen, 15)
c.Assert(ta.Indexes, HasLen, 3)
c.Assert(ta.PKColumns, DeepEquals, []int{2, 0})
c.Assert(ta.IsPrimaryKey(0), IsTrue)
c.Assert(ta.IsPrimaryKey(1), IsFalse)
c.Assert(ta.IsPrimaryKey(2), IsTrue)
c.Assert(ta.IsPrimaryKey(3), IsFalse)
c.Assert(ta.GetPKColumn(0), Equals, &ta.Columns[2])
c.Assert(ta.GetPKColumn(1), Equals, &ta.Columns[0])
c.Assert(ta.GetPKColumn(2), IsNil)
c.Assert(ta.GetPKColumn(3), IsNil)
c.Assert(ta.Indexes[0].Columns, HasLen, 2)
c.Assert(ta.Indexes[0].Name, Equals, "PRIMARY")
c.Assert(ta.Indexes[2].Name, Equals, "name_idx")
Expand All @@ -107,7 +117,7 @@ func (s *schemaTestSuite) TestSchema(c *C) {
c.Assert(ta.Columns[14].MaxSize, Equals, uint(12))
c.Assert(ta.Columns[14].FixedSize, Equals, uint(0))

taSqlDb, err := NewTableFromSqlDB(s.sqlDB, "test", "schema_test")
taSqlDb, err := NewTableFromSqlDB(s.sqlDB, *schema, "schema_test")
c.Assert(err, IsNil)

c.Assert(taSqlDb, DeepEquals, ta)
Expand All @@ -119,7 +129,7 @@ func (s *schemaTestSuite) TestQuoteSchema(c *C) {
_, err := s.conn.Execute(str)
c.Assert(err, IsNil)

ta, err := NewTable(s.conn, "test", "a-b_test")
ta, err := NewTable(s.conn, *schema, "a-b_test")
c.Assert(err, IsNil)

c.Assert(ta.Columns[0].Name, Equals, "a.b")
Expand Down