add String() for FieldValue #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
lance6716
commented
Sep 22, 2023
Signed-off-by: lance6716 <[email protected]>
lance6716
commented
Sep 22, 2023
| } | ||
|
|
||
| // test can directly use to build a SQL, though it's not safe in most cases | ||
| sql := fmt.Sprintf("INSERT INTO field_value_test VALUES (%s)", strings.Join(expected, ",")) |
There was a problem hiding this comment.
@zhujintao do you think it's OK to use?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #821