chore: update Go version to 1.17 #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robinlieb I think webhooks never defined the minimal Golang version it supported. So now it would be 1.16 for sure. Just want to pay attention if we are OK with it. |
|
@Toshik1978 would also make sense to use 1.17, the minimal version set in the workflow.yaml, and keep them in sync? Than I would update this PR / create a new one to set the Go version to 1.17. |
|
Yes, let's do it! Thanks! You can use this PR or create a new one. It's up to you! |
robinlieb
force-pushed
the
feat/go-1.20-update
branch
from
1e48a20 to
f60d7b2
Compare
robinlieb
changed the title
|
@Toshik1978 used this one and updated it to 1.17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.