feat(completion): let fish complete global tasks if -g or --global is passed #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, `set` may modify a global variable with the same name.
This comment was marked as resolved.
This comment was marked as resolved.
atusy
commented
Mar 21, 2025
completion/fish/task.fish
Outdated
| # Check if the global task is requested | ||
| set -l global_task false | ||
| set -l cmd_args | ||
| eval "set cmd_args $(commandline -b)" # split arguments by spaces while taking into account of quotes and escapes |
There was a problem hiding this comment.
eval is dangerous.
Let's say commandline is
$ foo --global; task
then eval evaluates
set cmd_args foo --global; task
which in turn
- evaluates
task default... - shows global tasks althoug
-gand--globalare not specified totask
There was a problem hiding this comment.
Okay, I found the problem can be fixed by selecting only a part of commandline instead of whole.
If this is still unlikely, I would avoid eval and instead simply split arguments by spaces.
set -l cmd_args "$commandline --current-process | string split ' '"
The caveat is that string split will complete global tasks in some unexpected cases (e.g., task "foo -g").
There was a problem hiding this comment.
Now I find a way to avoid eval!
read --tokenize is what we need.
…rsor before the fix, `eval` occasionally runs extra commands. ``` $ foo --global; task ``` then `eval` evaluates ``` set cmd_args foo --global; task ``` which in turn 1. evaluates `task default`... 2. shows global tasks althoug `-g` and `--global` are not specified to `task`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, fish completion suggests local tasks regardless of
-gor--globaloptions.This PR fixes the problem by adding a feature to detect these options and then suggesting global tasks if likely.
I hope this PR can be merged although I do not implement the feature for bash and zsh.
I am not familiar with them...