fix: dynamic variable caching does not take into account current dir

compiler.go

@@ -156,15 +156,18 @@ func (c *Compiler) HandleDynamicVar(v ast.Var, dir string, e []string) (string,
 	if c.dynamicCache == nil {
 		c.dynamicCache = make(map[string]string, 30)
 	}
-	if result, ok := c.dynamicCache[*v.Sh]; ok {
-		return result, nil
-	}
 
 	// NOTE(@andreynering): If a var have a specific dir, use this instead
 	if v.Dir != "" {
 		dir = v.Dir
 	}
 
+	cacheKey := *v.Sh + "-" + dir
+
+	if result, ok := c.dynamicCache[cacheKey]; ok {
+		return result, nil
+	}
+
 	var stdout bytes.Buffer
 	opts := &execext.RunCommandOptions{
 		Command: *v.Sh,
@@ -182,7 +185,7 @@ func (c *Compiler) HandleDynamicVar(v ast.Var, dir string, e []string) (string,
 	result := strings.TrimSuffix(stdout.String(), "\r\n")
 	result = strings.TrimSuffix(result, "\n")
 
-	c.dynamicCache[*v.Sh] = result
+	c.dynamicCache[cacheKey] = result
 	c.Logger.VerboseErrf(logger.Magenta, "task: dynamic variable: %q result: %q\n", *v.Sh, result)
 
 	return result, nil

task_test.go

@@ -3274,6 +3274,25 @@ func TestReference(t *testing.T) {
 	}
 }
 
+func TestResolveShellVarsInSubdirs(t *testing.T) {
+	t.Parallel()
+
+	var buff bytes.Buffer
+	e := task.NewExecutor(
+		task.ExecutorWithDir("testdata/includes_shell_vars"),
+		task.ExecutorWithStdout(&buff),
+		task.ExecutorWithStderr(&buff),
+		task.ExecutorWithSilent(true),
+		task.ExecutorWithForce(true),
+	)
+	require.NoError(t, e.Setup())
+	require.NoError(t, e.Run(context.Background(), &task.Call{Task: "all"}))
+
+	output := buff.String()
+	require.Contains(t, output, `[s1:all] ./a`)
+	require.Contains(t, output, `[s2:all] ./b`)
+}
+
 func TestVarInheritance(t *testing.T) {
 	enableExperimentForTest(t, &experiments.EnvPrecedence, 1)
 	tests := []struct {

testdata/includes_shell_vars/Taskfile.yml

@@ -0,0 +1,20 @@
+version: '3'
+
+run: when_changed
+silent: true
+output: prefixed
+
+includes:
+  s1:
+    taskfile: sub1
+    dir: sub1
+  s2:
+    taskfile: sub2
+    dir: sub2
+
+tasks:
+  all:
+    deps:
+      - s1:all
+      - s2:all
+

testdata/includes_shell_vars/sub1/Taskfile.yml

@@ -0,0 +1,10 @@
+version: '3'
+
+vars:
+  files:
+    sh: "find ."
+
+tasks:
+  all:
+    cmds:
+      - cmd: 'echo  "{{.files}}"'

testdata/includes_shell_vars/sub1/a

@@ -0,0 +1 @@
+AAA

testdata/includes_shell_vars/sub2/Taskfile.yml

@@ -0,0 +1,10 @@
+version: '3'
+
+vars:
+  files:
+    sh: "find ."
+
+tasks:
+  all:
+    cmds:
+      - cmd: 'echo  "{{.files}}"'

testdata/includes_shell_vars/sub2/b

@@ -0,0 +1 @@
+BBB