Skip to content

feat: recursive config search #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: recursive config search #2166

wants to merge 6 commits into from

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Apr 5, 2025

Fixes #2014

This PR changes how the experiments package initialises experiments. It allows them to be enabled by calling experiments.Parse() instead of relying on an init() function. This solves the issues raised in #2014, but also makes it easier to support loading experiments from other sources (such as config files).

Fixes #2159

The code to load a .taskrc.yml config has been moved out of the experiments package to make it more generic (it may be used for other things in the future). A new taskrc package has been created for this purpose that aligns with the equivalent taskfile package for loading Taskfiles. They have a very similar structure, although taskrc doesn't need to be anything like as complicated as the concepts of includes, remote files, node types and caching are all irrelevant at this time.

Some of the utilities used by both the taskfile and taskrc packages have been pulled out into a new fsext package. The advantage of this is that taskrc now gets access to powerful functions that let us search dynamically for files recursively up the file tree.

I have also (as usual) tried to tidy up a few bits of code as I went.

@pd93 pd93 changed the title recursive config search feat: recursive config search Apr 5, 2025
@pd93 pd93 force-pushed the recursive-config-search branch from aae4447 to 1331cb8 Compare April 5, 2025 22:51
@pd93 pd93 marked this pull request as ready for review April 6, 2025 00:12
@pd93 pd93 requested review from vmaerten and andreynering April 10, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.taskrc.yml and .env not found when in a sub folder Programmatically enable experiments
1 participant