feat: remote taskfile improvements (cache/expiry) #2176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1402
This PR makes a series of changes to the remote taskfiles experiment:
taskfile/reader.go
and related error handling.RemoteNode
interface which distinguishes between a regularNode
and remote ones. This replaces the existingfunc Remote() bool
method.ctx
into theReader.Read
method to use for cancellation instead of a timeout functional option. The CLI will set the context with a timeout according to the current timeout flag--expriy
flag which will set the expiry duration for the cache.Future work:
.taskrc
/env var setting for cache expiry durationThis is based on the
package-api-docs
branch for now. It will need a rebase. It also conflicts heavily with other in progress work.