Remove deprecated symbols from before v0.1 #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
force-pushed
the
qol/remove-deprecated
branch
from
391711c to
c076f81
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Remove deprecated symbols from before v0.1
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-808 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Bromeon
force-pushed
the
qol/remove-deprecated
branch
2 times, most recently
from
0511454 to
d75810c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These symbols were already deprecated before v0.1 and have been kept in the initial crates.io release for compatibility. However, some of them caused confusion for IDE imports (same symbol in 2 modules) as well as for Rustdoc intra-doc links.
The export flag
radians(replaced withradians_as_degrees) stays because it's deprecated in Godot, and when retaining compatibility with 4.1, we need to support it. However, it keeps creating a deprecation warning for >= 4.2.The old
GString::chars_[un]checkedmethods stay for now, but will be removed alongside 4.0 support.