Skip to content

Dev-dependencies are enabling full codegen #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

TitanNano
Copy link
Contributor

The godot crate is used as a dev-dependency in godot-core and godot-macros, but the default features are not disabled. This enables full code gen when the tests of these crates are being compiled, even when passing --no-default-features.

(I pulled this out of #771 as it isn't really connected with required virtual methods.)

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-842

@Bromeon Bromeon added bug c: tooling CI, automation, tools labels Aug 6, 2024
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great catch!

I assume this still works in full codegen mode, because godot was provided with more features in the first place (non-dev dependencies), right?

@TitanNano TitanNano force-pushed the jovan/dev_dep_codegen branch from 78c9688 to e759511 Compare August 6, 2024 08:26
@TitanNano
Copy link
Contributor Author

I assume this still works in full codegen mode, because godot was provided with more features in the first place (non-dev dependencies), right?

yes, compiling cargo build still works and cargo build --no-default-features should no longer enable full codegen. Same for tests and clippy.

@Bromeon Bromeon added this pull request to the merge queue Aug 6, 2024
Merged via the queue into godot-rust:master with commit 884b5d9 Aug 6, 2024
14 checks passed
@TitanNano TitanNano deleted the jovan/dev_dep_codegen branch August 6, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: tooling CI, automation, tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants