Fix compute shader so uniforms are the same #1174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, - set 0 and 1 were read-only, and - set 1 was write-only Metal's SPIR-V reflection implementation correctly distinguished these attributes, and resulted in the failure described by issue godotengine/godot#101696 A fix for Godot's default SPIR-V reflection is found in godotengine/godot#103614 To ensure the demo keeps working, we ensure all sets have matching formats.
clayjohn
approved these changes
Mar 7, 2025
Calinou
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Looks good to me, but please keep the tab indentation within the shader file (it was converted to spaces).
The Godot shader style guide recommends tabs for indentation, and while GLSL is not the same as Godot shaders, it's fair to assume the same recommendations apply. (We should make this explicit in the docs still.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Metal's SPIR-V reflection implementation correctly distinguished these attributes, and resulted in the failure described by issue godotengine/godot#101696
A fix for Godot's default SPIR-V reflection is found in godotengine/godot#103614
To ensure the demo keeps working, we ensure all sets have matching formats.