Exposes in API the Repo entity's Size and Isempty properties #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
reviewed
May 4, 2017
repo.go
Outdated
| @@ -27,6 +27,8 @@ type Repository struct { | |||
| Description string `json:"description"` | |||
| Private bool `json:"private"` | |||
| Fork bool `json:"fork"` | |||
| Empty bool `json:"empty"` | |||
| Size bool `json:"size"` | |||
There was a problem hiding this comment.
fixed as you were writing that 😁
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
a38eca4 to
66b7d30
Compare
This was referenced May 4, 2017
guyzmo
added a commit
to guyzmo/git-repo
that referenced
this pull request
May 4, 2017
for Gogs/Gitea, API is not yet out, cf following PRs: cf unfoldingWord-dev/python-gitea-client#9 cf go-gitea/go-sdk#56 cf gogs/gogs#4484 cf gogs/go-gogs-client#64 cf https://github.com/gogits/gogs/pull/4484o fixes #129
guyzmo
added a commit
to guyzmo/git-repo
that referenced
this pull request
May 4, 2017
for Gogs/Gitea, API is not yet out, cf following PRs: cf unfoldingWord-dev/python-gitea-client#9 cf go-gitea/go-sdk#56 cf gogs/gogs#4484 cf gogs/go-gogs-client#64 cf gogs/gogs#4484 fixes #129
guyzmo
added a commit
to guyzmo/git-repo
that referenced
this pull request
May 4, 2017
for Gogs/Gitea, API is not yet out, cf following PRs: cf unfoldingWord-dev/python-gitea-client#9 cf go-gitea/go-sdk#56 cf go-gitea/gitea#1668 cf gogs/gogs#4484 cf gogs/go-gogs-client#64 fixes #129
|
is there still an issue? |
This was referenced May 5, 2017
guyzmo
added a commit
to guyzmo/gogs
that referenced
this pull request
May 5, 2017
Signed-off-by: Guyzmo <[email protected]>
This was referenced May 5, 2017
guyzmo
added a commit
to guyzmo/gogs
that referenced
this pull request
May 5, 2017
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
932264d to
150f22a
Compare
* Add new field "Empty" to Repository structure * Fix Empty type to bool * Add Size property to Repository structure Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
150f22a to
dcc0d6c
Compare
guyzmo
added a commit
to guyzmo/gogs
that referenced
this pull request
May 10, 2017
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
dcc0d6c to
6fb98c4
Compare
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
6fb98c4 to
9769715
Compare
|
is it ok? FYI, I've had that same change accepted and merged into gitea, I did my best to make sure any changes they required from me has been mirrored in that branch, but I can have done some mistakes! |
|
Yeah, I didn't notice the correlated PR in the Gogs mai repository. Should be able review and merge tonight. |
|
brilliant 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf gogs/gogs#4484