Skip to content

Commit 0d2316b

Browse files
drakkangopherbot
authored andcommitted
ssh/test: work around for TestCiphers failures on macOS
TestCiphers is already skipped on macOS when testing data received from the server, so move the test for sending data after the receiving one to work around this new integration test failure. Fixes golang/go#65732 Change-Id: Ie0c614c5373735ae8aefdd7ded643579b130f4b3 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564457 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Nicola Murino <[email protected]> Commit-Queue: Nicola Murino <[email protected]>
1 parent 0aab8d0 commit 0d2316b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ssh/test/session_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -357,11 +357,6 @@ func testOneCipher(t *testing.T, cipher string, cipherOrder []string) {
357357

358358
numBytes := 4096
359359

360-
// Exercise sending data to the server
361-
if _, _, err := conn.Conn.SendRequest("drop-me", false, make([]byte, numBytes)); err != nil {
362-
t.Fatalf("SendRequest: %v", err)
363-
}
364-
365360
// Exercise receiving data from the server
366361
session, err := conn.NewSession()
367362
if err != nil {
@@ -377,6 +372,11 @@ func testOneCipher(t *testing.T, cipher string, cipherOrder []string) {
377372
if len(out) != numBytes {
378373
t.Fatalf("got %d bytes, want %d bytes", len(out), numBytes)
379374
}
375+
376+
// Exercise sending data to the server
377+
if _, _, err := conn.Conn.SendRequest("drop-me", false, make([]byte, numBytes)); err != nil {
378+
t.Fatalf("SendRequest: %v", err)
379+
}
380380
}
381381

382382
var deprecatedCiphers = []string{

0 commit comments

Comments
 (0)