Skip to content

x/crypto/ssh/test: TestCiphers failures on macOS #65732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Feb 15, 2024 · 8 comments
Open

x/crypto/ssh/test: TestCiphers failures on macOS #65732

gopherbot opened this issue Feb 15, 2024 · 8 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Feb 15, 2024 •
edited by bcmills
Loading 

#!watchflakes
post <- goos == "darwin" && pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestCiphers/[email protected]
    session_test.go:362: SendRequest: EOF
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/[email protected] (0.10s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/crypto/ssh/test" && test == "TestCiphers/[email protected]"
2024-02-07 19:12 x_crypto-go1.22-darwin-amd64-longtest crypto@405cb3bd release-branch.go1.22@20107e05 x/crypto/ssh/test.TestCiphers/[email protected] (log) 
=== RUN   TestCiphers/[email protected]
    session_test.go:362: SendRequest: EOF
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest1184070208/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/[email protected] (0.10s)

— watchflakes

@cherrymui cherrymui changed the title x/crypto/ssh/test: TestCiphers/[email protected] failures x/crypto/ssh/test: TestCiphers failures Feb 15, 2024
@cherrymui cherrymui mentioned this issue Feb 15, 2024
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`
2024-02-08 16:32 x_crypto-go1.22-darwin-amd64-longtest crypto@62c9f179 release-branch.go1.22@20107e05 x/crypto/ssh/test.TestCiphers/3des-cbc (log) 
=== RUN   TestCiphers/3des-cbc
    session_test.go:369: NewSession: write unix ->/Users/swarming/.swarming/w/ir/x/t/unixConnection2186664944/ssh: write: broken pipe
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest2583648940/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest2583648940/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest2583648940/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest2583648940/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/3des-cbc (0.13s)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 16, 2024

This may be related to #64959 (attn @drakkan).

@bcmills bcmills changed the title x/crypto/ssh/test: TestCiphers failures x/crypto/ssh/test: TestCiphers failures on macOS Feb 16, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/564457 mentions this issue: ssh/test: workaround for TestCiphers failures on macOS

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "darwin" && pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`
2024-02-15 13:30 x_crypto-gotip-darwin-amd64-longtest crypto@1a865804 go@af5943f9 x/crypto/ssh/test.TestCiphers/arcfour256 (log) 
=== RUN   TestCiphers/arcfour256
    session_test.go:369: NewSession: write unix ->/Users/swarming/.swarming/w/ir/x/t/unixConnection32437896/ssh: write: broken pipe
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest2448938609/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest2448938609/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest2448938609/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest2448938609/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/arcfour256 (0.13s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "darwin" && pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`
2024-02-18 02:21 x_crypto-go1.22-darwin-amd64-longtest crypto@5bead598 release-branch.go1.22@6cbe522f x/crypto/ssh/test.TestCiphers/[email protected] (log) 
=== RUN   TestCiphers/[email protected]
    session_test.go:369: NewSession: write unix ->/Users/swarming/.swarming/w/ir/x/t/unixConnection3239750690/ssh: use of closed network connection
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest2393354808/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest2393354808/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest2393354808/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest2393354808/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/[email protected] (0.17s)
2024-02-26 19:05 x_crypto-gotip-darwin-amd64-longtest crypto@0aab8d07 go@2278ffcb x/crypto/ssh/test.TestCiphers/3des-cbc (log) 
=== RUN   TestCiphers/3des-cbc
    session_test.go:369: NewSession: write unix ->/Users/swarming/.swarming/w/ir/x/t/unixConnection3398320224/ssh: write: broken pipe
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest571752962/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest571752962/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest571752962/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest571752962/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/3des-cbc (0.13s)

— watchflakes

@gopherbot gopherbot reopened this May 6, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "darwin" && pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`
2024-05-06 13:42 x_crypto-go1.22-darwin-amd64-longtest crypto@905d78a6 release-branch.go1.22@93d8777d x/crypto/ssh/test.TestCiphers/aes128-cbc (log) 
=== RUN   TestCiphers/aes128-cbc
    session_test.go:364: NewSession: EOF
    test_unix_test.go:241: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest2503863088/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest2503863088/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest2503863088/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest2503863088/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestCiphers/aes128-cbc (0.15s)

— watchflakes

drakkan added a commit to drakkan/crypto that referenced this issue May 11, 2024
@drakkan
ssh/test: work around for TestCiphers failures on macOS
5f9921a 
TestCiphers is already skipped on macOS when testing data received
from the server, so move the test for sending data after the
receiving one to work around this new integration test failure.

Fixes golang/go#65732

Change-Id: Ie0c614c5373735ae8aefdd7ded643579b130f4b3
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564457
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Nicola Murino <[email protected]>
Commit-Queue: Nicola Murino <[email protected]>
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "darwin" && pkg == "golang.org/x/crypto/ssh/test" && test ~ `TestCiphers`
2025-01-02 16:15 x_crypto-gotip-darwin-amd64-longtest crypto@4a75ba54 go@5da02635 x/crypto/ssh/test.TestCiphers/[email protected] (log) 
=== RUN   TestCiphers/[email protected]
    session_test.go:364: NewSession: EOF
    test_unix_test.go:246: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Users/swarming/.swarming/w/ir/x/t/sshtest261735111/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Users/swarming/.swarming/w/ir/x/t/sshtest261735111/sshd_config line 11: Deprecated option ServerKeyBits
        /Users/swarming/.swarming/w/ir/x/t/sshtest261735111/sshd_config line 17: Deprecated option RSAAuthentication
        /Users/swarming/.swarming/w/ir/x/t/sshtest261735111/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user swarming authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        Could not create new audit session
        debug1: do_cleanup
--- FAIL: TestCiphers/[email protected] (0.18s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot