This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Path sanity check fails when $GOPATH contains double slashes. #1946
Comments
|
Yeah, seems like this should be pretty easy. PR welcome 😄 |
jpentland
added a commit
to jpentland/dep
that referenced
this issue
Jul 18, 2018
Removes artefacts such as trailing and repeated separators, directory
navigation symbols ('./' '../').
Also add a test case to ensure that repeated separators are handled
correctly (relevant for golang#1946).
jpentland
added a commit
to jpentland/dep
that referenced
this issue
Jul 18, 2018
Removes artefacts such as trailing and repeated separators, directory
navigation symbols ('./' '../').
Also add a test case to ensure that repeated separators are handled
correctly (relevant for golang#1946).
jpentland
added a commit
to jpentland/dep
that referenced
this issue
Jul 18, 2018
Removes artifacts such as trailing and repeated separators, directory
navigation symbols ('./' '../').
Also add a test case to ensure that repeated separators are handled
correctly (relevant for golang#1946).
|
PR here #1948 |
sdboyer
added a commit
that referenced
this issue
Jul 23, 2018
Improve handling of paths containing repeated separators (fix #1946).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
My $GOPATH was set to
/home/user//.gopath. In the beginning dep checks to make sure it is being run in gopath. This check fails in this case because the PWD will be/home/user/.gopath/src, without the two slashes.The reason for the double slash was a system misconfig where /etc/passwd contained a trailing slash for the user home directory, so
~/.gopathresults in two slashes.It should be possible to sanitise the GOPATH and the PWD first before comparing that they match.
What version of
depare you using (dep version)?What
depcommand did you run?The text was updated successfully, but these errors were encountered: