Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Make git commands nosier. #859

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Make git commands nosier. #859

merged 1 commit into from
Jul 21, 2017

Conversation

DDRBoxman
Copy link
Contributor

Git commands have flags passed to them to make them more verbose and spit out progress. This should help us not pre-emptively think a process has died when it hasn't.

This might mitigate some issues in #832.

I still need to figure out how to get git-lfs to be noisier.

@DDRBoxman DDRBoxman requested a review from sdboyer as a code owner July 20, 2017 05:06
@sdboyer
Copy link
Member

sdboyer commented Jul 20, 2017

oh, this definitely seems like a good idea. i guess the weird thing is how long git clones have been surviving at ALL with our monitored system, without this kind of progress indicator :/

can you find out when those options were added, though? we don't have a hard rule on what our minimum git version is currently, but i've generally avoided relying on features that are >5 years old thus far.

@DDRBoxman
Copy link
Contributor Author

git clone:

git checkout:

@sdboyer
Copy link
Member

sdboyer commented Jul 20, 2017

OK, let's keep the clone, but 1.5 years is a little too recent for checkout. (Fortunately, I'm more concerned about clone than checkout).

@sdboyer
Copy link
Member

sdboyer commented Jul 21, 2017

great, thank you, that'll do it!

happy first PR! 🎉

@sdboyer sdboyer merged commit d8abc57 into golang:master Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants