Skip to content

Add ChainInterpolationQuery #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Add ChainInterpolationQuery #110

Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d13cf4f
udpated Chain method impls
pavlov061356 Sep 26, 2024
e3b5644
added required functions and starting to write tests
pavlov061356 Sep 30, 2024
86ce61b
adding tests
pavlov061356 Oct 1, 2024
843e2d9
updating tests
pavlov061356 Oct 1, 2024
984d3f1
finished SimplePolylines test
pavlov061356 Oct 2, 2024
6d9b45f
finished with tests && fixing
pavlov061356 Oct 2, 2024
d5e1fb8
testing + fixing
pavlov061356 Oct 3, 2024
18c8000
finished with ChainINtepolationQueryTest
pavlov061356 Oct 4, 2024
95e8284
fixed PointVector Chain method
pavlov061356 Oct 4, 2024
d95a469
renamed InitChainInterpolationQuery
pavlov061356 Oct 4, 2024
3046c85
added docs
pavlov061356 Oct 4, 2024
665d021
typo
pavlov061356 Oct 4, 2024
bab758c
TestSlice update
pavlov061356 Oct 4, 2024
ded5834
updated TestChains
pavlov061356 Oct 4, 2024
94c0548
TestGetLengthAtEdgePolyline updated
pavlov061356 Oct 4, 2024
c052091
TestGetLengthAtEdgePolygon updated
pavlov061356 Oct 4, 2024
1a40a64
TestSimplePolylines updated
pavlov061356 Oct 4, 2024
47bb065
added SliceDivided
pavlov061356 Oct 4, 2024
409019d
add calculateDivisionsByEdge method
pavlov061356 Oct 7, 2024
3756e6b
starting to add benchmark on calculateDivisionsByEdge
pavlov061356 Oct 7, 2024
ad17ebc
adding tests for start and end edge ids for calculateDivisionsByEdge
pavlov061356 Oct 7, 2024
e6eb2de
updating SliceDivided
pavlov061356 Oct 8, 2024
c42b6ff
fixed & finished with ChainInterpolationQuery.AddSliceDivided
pavlov061356 Oct 14, 2024
c9f97d5
remove unused
pavlov061356 Oct 14, 2024
2ffcfa6
additional test
pavlov061356 Oct 14, 2024
9ca2a9b
try to rename module
pavlov061356 Oct 14, 2024
6bdb0c2
testing fix for overfill of SliceDivided
pavlov061356 Oct 16, 2024
dcffae9
testing fix for overfill of SliceDivided
pavlov061356 Oct 16, 2024
d57db6b
refactoring
pavlov061356 Nov 11, 2024
0119655
updated with non emptu slice
pavlov061356 Nov 11, 2024
8f84d8d
Merge branch 'ft/s2/add_chain_interpolation_query'
pavlov061356 Nov 11, 2024
b86616f
add benchmark on slice divided
pavlov061356 Nov 13, 2024
e9400b5
add benchmark results
pavlov061356 Nov 13, 2024
c5a9edf
updated alloc rate
pavlov061356 Nov 13, 2024
ea1220a
optimized memory allocation
pavlov061356 Nov 14, 2024
785e252
Merge branch 'ft/add_benchamarks'
pavlov061356 Nov 14, 2024
d02b7e1
add benchmark
pavlov061356 Nov 18, 2024
d398ea8
Update README.md
pavlov061356 Nov 20, 2024
cd9bd72
udpated length check
pavlov061356 Nov 22, 2024
fc6dc25
refactored filling divided slice
pavlov061356 Nov 22, 2024
d6fc39f
fixed reverse in SliceDivided
pavlov061356 Dec 11, 2024
e711090
updated to point with fraction to SliceDivided
pavlov061356 Dec 12, 2024
75f9537
Merge branch 'master' into ft/s2/add_chain_interpolation_query
pavlov061356 Apr 11, 2025
54d58af
slice divided update
pavlov061356 Apr 11, 2025
dcb138f
Merge branch 'master' into ft/s2/add_chain_interpolation_query
pavlov061356 Apr 11, 2025
7ea6a4b
review update
pavlov061356 Apr 11, 2025
7cfaa88
review updates
pavlov061356 Apr 11, 2025
b68cc23
package name fix
pavlov061356 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ VertexIDLaxLoop | ❌

C++ Type | Go
:------------------- | ---
S2ChainInterpolation | ❌
S2ChainInterpolation | ✅
S2ClosestCell | ❌
S2FurthestCell | ❌
S2ClosestEdge | ✅
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/golang/geo
module github.com/pavlov061356/geo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing every file, which makes it hard to see where the real changes are.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it


go 1.21

Expand Down
2 changes: 1 addition & 1 deletion r2/rect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"fmt"
"math"

"github.com/golang/geo/r1"
"github.com/pavlov061356/geo/r1"
)

// Point represents a point in ℝ².
Expand Down
2 changes: 1 addition & 1 deletion r2/rect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"reflect"
"testing"

"github.com/golang/geo/r1"
"github.com/pavlov061356/geo/r1"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion r3/vector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"fmt"
"math"

"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/s1"
)

// Vector represents a point in ℝ³.
Expand Down
2 changes: 1 addition & 1 deletion s1/example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"fmt"
"math"

"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/s1"
)

func ExampleInterval_DirectedHausdorffDistance() {
Expand Down
2 changes: 1 addition & 1 deletion s2/builder_snapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package s2
import (
"math"

"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/s1"
)

// A Snapper restricts the locations of the output vertices. For
Expand Down
2 changes: 1 addition & 1 deletion s2/builder_snapper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package s2
import (
"testing"

"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/s1"
)

func TestIdentitySnapper(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions s2/cap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import (
"io"
"math"

"github.com/golang/geo/r1"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r1"
"github.com/pavlov061356/geo/s1"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions s2/cap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (
"math"
"testing"

"github.com/golang/geo/r3"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r3"
"github.com/pavlov061356/geo/s1"
)

const (
Expand Down
8 changes: 4 additions & 4 deletions s2/cell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ import (
"io"
"math"

"github.com/golang/geo/r1"
"github.com/golang/geo/r2"
"github.com/golang/geo/r3"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r1"
"github.com/pavlov061356/geo/r2"
"github.com/pavlov061356/geo/r3"
"github.com/pavlov061356/geo/s1"
)

// CellBoundary represents canonical identifiers for the boundaries of the cell.
Expand Down
4 changes: 2 additions & 2 deletions s2/cell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import (
"testing"
"unsafe"

"github.com/golang/geo/r2"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r2"
"github.com/pavlov061356/geo/s1"
)

// maxCellSize is the upper bounds on the number of bytes we want the Cell object to ever be.
Expand Down
8 changes: 4 additions & 4 deletions s2/cellid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ import (
"strconv"
"strings"

"github.com/golang/geo/r1"
"github.com/golang/geo/r2"
"github.com/golang/geo/r3"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r1"
"github.com/pavlov061356/geo/r2"
"github.com/pavlov061356/geo/r3"
"github.com/pavlov061356/geo/s1"
)

// CellID uniquely identifies a cell in the S2 cell decomposition.
Expand Down
4 changes: 2 additions & 2 deletions s2/cellid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import (
"reflect"
"testing"

"github.com/golang/geo/r2"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r2"
"github.com/pavlov061356/geo/s1"
)

func TestCellIDFromFace(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion s2/cellunion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"io"
"sort"

"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/s1"
)

// A CellUnion is a collection of CellIDs.
Expand Down
4 changes: 2 additions & 2 deletions s2/cellunion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import (
"reflect"
"testing"

"github.com/golang/geo/r1"
"github.com/golang/geo/s1"
"github.com/pavlov061356/geo/r1"
"github.com/pavlov061356/geo/s1"
)

func TestCellUnionDuplicateCellsNotValid(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion s2/centroids.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package s2
import (
"math"

"github.com/golang/geo/r3"
"github.com/pavlov061356/geo/r3"
)

// There are several notions of the "centroid" of a triangle. First, there
Expand Down
2 changes: 1 addition & 1 deletion s2/centroids_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"math"
"testing"

"github.com/golang/geo/r3"
"github.com/pavlov061356/geo/r3"
)

func TestCentroidsPlanarCentroid(t *testing.T) {
Expand Down
Loading