Skip to content

tests: Remove outdated flaky test comments #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

tests: Remove outdated flaky test comments #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions s2/convex_hull_query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ func TestConvexHullQueryLoopsAroundNorthPole(t *testing.T) {
}

func TestConvexHullQueryPointsInsideHull(t *testing.T) {
// TODO: Verify if it's still about 0.3% flaky with a random seed.
// TODO(rsned): https://github.com/golang/geo/issues/120

// Repeatedly build the convex hull of a set of points, then add more points
// inside that loop and build the convex hull again. The result should
// always be the same.
Expand Down
3 changes: 0 additions & 3 deletions s2/edge_clipping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ func testClipToPaddedFace(t *testing.T, a, b Point) {
}

func TestEdgeClippingClipToPaddedFace(t *testing.T) {
// TODO: Verify if it's still about 1.2% flaky with a random seed.
// TODO(rsned): https://github.com/golang/geo/issues/120

// Start with a few simple cases.
// An edge that is entirely contained within one cube face:
testClipToPaddedFace(t, Point{r3.Vector{X: 1, Y: -0.5, Z: -0.5}}, Point{r3.Vector{X: 1, Y: 0.5, Z: 0.5}})
Expand Down
3 changes: 0 additions & 3 deletions s2/paddedcell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@ func TestPaddedCellEntryExitVertices(t *testing.T) {
}

func TestPaddedCellShrinkToFit(t *testing.T) {
// TODO: Verify if it's still about 0.2% flaky with a random seed.
// TODO(rsned): https://github.com/golang/geo/issues/120

for iter := 0; iter < 1000; iter++ {
// Start with the desired result and work backwards.
result := randomCellID()
Expand Down
3 changes: 0 additions & 3 deletions s2/point_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ func TestPointDistance(t *testing.T) {
}

func TestChordAngleBetweenPoints(t *testing.T) {
// TODO: Verify if it's still about 0.2% flaky with a random seed.
// TODO(rsned): https://github.com/golang/geo/issues/120

for iter := 0; iter < 100; iter++ {
m := randomFrame()
x := m.col(0)
Expand Down
3 changes: 0 additions & 3 deletions s2/s2_test_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ func numVerticesAtLevel(level int) int {
}

func TestTestingFractal(t *testing.T) {
// TODO: Verify if it's about 2.4% flaky with a random seed, due to CesaroMultiFractal.
// TODO(rsned): https://github.com/golang/geo/issues/120

tests := []struct {
label string
minLevel int
Expand Down