x/net, x/crypto: CONTRIBUTING.md still says GitHub pull requests are not accepted #24185
Comments
|
/cc @andybons |
bradfitz
added
the
NeedsFix
|
Also found these in other golang org repos. |
|
Change https://golang.org/cl/100676 mentions this issue: |
|
Change https://golang.org/cl/100677 mentions this issue: |
|
Change https://golang.org/cl/100678 mentions this issue: |
|
Change https://golang.org/cl/100679 mentions this issue: |
|
Change https://golang.org/cl/100680 mentions this issue: |
|
Change https://golang.org/cl/100681 mentions this issue: |
|
Change https://golang.org/cl/100682 mentions this issue: |
|
Change https://golang.org/cl/100683 mentions this issue: |
|
Change https://golang.org/cl/100684 mentions this issue: |
|
Change https://golang.org/cl/100685 mentions this issue: |
|
Change https://golang.org/cl/100686 mentions this issue: |
|
Change https://golang.org/cl/100687 mentions this issue: |
|
Change https://golang.org/cl/100688 mentions this issue: |
|
Change https://golang.org/cl/100689 mentions this issue: |
|
Change https://golang.org/cl/100690 mentions this issue: |
|
Change https://golang.org/cl/100691 mentions this issue: |
|
Change https://golang.org/cl/100695 mentions this issue: |
|
Change https://golang.org/cl/100696 mentions this issue: |
|
Change https://golang.org/cl/100692 mentions this issue: |
|
Change https://golang.org/cl/100693 mentions this issue: |
|
Change https://golang.org/cl/100694 mentions this issue: |
|
Change https://golang.org/cl/100715 mentions this issue: |
|
Change https://golang.org/cl/100697 mentions this issue: |
|
Change https://golang.org/cl/100716 mentions this issue: |
|
Change https://golang.org/cl/100717 mentions this issue: |
Updates golang/go#24185 Change-Id: I74b024457ece54c6b02c3b017cb003142b75b4f8 Reviewed-on: https://go-review.googlesource.com/100690 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I892f30f02f9ae40554790e9c177cb79d193bffd5 Reviewed-on: https://go-review.googlesource.com/100696 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ia2de9218885e0cfeaec79ed7417475230b063df0 Reviewed-on: https://go-review.googlesource.com/100692 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ib544ebd3a7b3f2bd621e5054235a174358909042 Reviewed-on: https://go-review.googlesource.com/100693 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I582f013c13651c71d6fdf48be3b5e8ddf0341e80 Reviewed-on: https://go-review.googlesource.com/100694 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I54972e6370a1de467b36c58e69483d0b42350c88 Reviewed-on: https://go-review.googlesource.com/100697 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I7f19310ff4dba014c3dff9b7d7791bfdcb4ebd44 Reviewed-on: https://go-review.googlesource.com/100677 Reviewed-by: Andrew Bonventre <[email protected]>
Updates golang/go#24185 Change-Id: I6462c066b7efc4086496d9ed5e85a0d826f962bd Reviewed-on: https://go-review.googlesource.com/100716 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ic2d895e46e2aac8ccf4ac835a3c945cfaaec65b8 Reviewed-on: https://go-review.googlesource.com/100717 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ic0522fc0f682cd2fe60aa3081a47a025a76d7f9c Reviewed-on: https://go-review.googlesource.com/100678 Reviewed-by: Andrew Bonventre <[email protected]>
Updates golang/go#24185 Change-Id: I6bd8b9a38e9a22793a2791a2d46e7ea4087bff7a Reviewed-on: https://go-review.googlesource.com/100676 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I83709d8356c2d64d1e5bfe2fafe3a0436d57dc3c Reviewed-on: https://go-review.googlesource.com/100688 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I364b3583276d66057344e109e6ea413c6120191c Reviewed-on: https://go-review.googlesource.com/100687 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I2cc878ba8ba163215a6430154bead5c79a5c5206 Reviewed-on: https://go-review.googlesource.com/100686 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ifbd5b9c8c8bb11635c49a390a8deda8bfed8e849 Reviewed-on: https://go-review.googlesource.com/100685 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I1ce066be52feff5d2372633776aa631e0ce7e713 Reviewed-on: https://go-review.googlesource.com/100684 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I9a3a920ec803ee612775aebfeaedb162d2266aa8 Reviewed-on: https://go-review.googlesource.com/100683 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I10753a1e9829a7b2f74c3e9bade62f8a1d4ef9e1 Reviewed-on: https://go-review.googlesource.com/100682 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I7754e0bca3662aa9f930b796a59135e748b94707 Reviewed-on: https://go-review.googlesource.com/100680 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I228e34ceb525d5d41d1146ef17d6f958a143026e Reviewed-on: https://go-review.googlesource.com/100681 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: I99281b2bd1c1ca82c02269d232d7714852a3b94c Reviewed-on: https://go-review.googlesource.com/100679 Reviewed-by: Ian Lance Taylor <[email protected]>
Updates golang/go#24185 Change-Id: Ic13f841b951220fdb271956184e13e8f8e16eba6 Reviewed-on: https://go-review.googlesource.com/100689 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
|
The remaining notes about this have been removed. Thanks for collecting the instances, @jlburkhead! |
Updates golang/go#24185 Change-Id: Ic2d895e46e2aac8ccf4ac835a3c945cfaaec65b8 Reviewed-on: https://go-review.googlesource.com/100717 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
|
@andybons The notice PR in the oauth2 package is still open: golang/oauth2#218 |
|
@bontibon closed. Thanks! |
What did you do?
I opened a trivial pull request against golang.org/x/crypto, and gerritbot converted my PR to a CL as expected.
What did you expect to see?
CONTRIBUTING.md should not have said "We do not accept GitHub pull requests", but perhaps should have mentioned gerritbot.
What did you see instead?
I noticed the same message on x/net/CONTRIBUTING.md, but I did not check any other x/ repositories.
The text was updated successfully, but these errors were encountered: