x/pkgsite: support Refresh now like godoc.org
#37106
Labels
FeatureRequest
Issues asking for a new feature that does not need a proposal.
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
pkgsite
Milestone
Comments
cagedmantis
added
FeatureRequest
|
/cc @julieqiu |
|
Related to #36811 |
|
Thanks for the feedback! We are currently working on a fix for this. Also related is #37002 |
14 tasks
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
The logic for GetVersionMap is changed so that an explicit module path is now required. All logic is also now the same for all requestedVersions (as opposed to a special case for latest). This function is only used by the frontend to check if a version exists as part of a frontend fetch, and this behavior makes more sense for that use case. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: I415a2730daa6edc023f80c0c615521047311f35b Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/744833 Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
The frontend server is not initiated with a queue. The frontend task queue will be used to support frontend fetches. frontend.FetchAndUpdateState is added, which is a copy of worker.FetchAndUpdateState for use in testing and locally. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: I41922d30462d2623a061aa1f207bb2b39f7b54e2 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/743102 Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
This column will be used to display the canonical module path when a frontend fetch results in fetching an alternative module path. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: Ie8ee6ba64ea799d264c1079c345e37d2e073da38 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/751268 Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
The version_map.go_mod_path column is now populated in UpsertVersionMap. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: I4e474d28bee67caf7625045082df46f93394f3f6 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/751269 Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
FetchAndUpdateState in internal/frontend and internal/worker now insert the GoModPath field on VersionMap. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: Idfce6d685d24d915608acc1748a84b9db5312ae4 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/751270 CI-Result: Cloud Build <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
A fetch endpoint is added to the frontend, which will queue a module to be enqueued by the worker, if it doesn't already exist in the database. After enqueuing, the fetch handler will poll the version_map table at a constant rate, until the path returns or the request times out. If the request fails, a corresponding statusCode and responseText will be returned to be displayed to the user. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: Ic2e20146dc626bf296db05bc2abbfb50d6fd7991 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/743103 CI-Result: Cloud Build <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
When a path page 404s, it will now render the notfound.tmpl page (once the frontend-fetch feature flag is on), which provides a button for the user to make a request to fetch the package. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: I17fedd018435e8d3e51e2a2a4a972d3cf673df56 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/753606 CI-Result: Cloud Build <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jun 15, 2020
At the moment when a request for path@version 404s, but other versions of the path exists, we will return an error message letting users know that is the case. Once frontend fetch is live, the message will change to provide users an option to fetch that version of the path. This logic is moved to pathFoundAtLatestError. Updates golang/go#36811 Updates golang/go#37002 Updates golang/go#37106 Change-Id: I1ad15ee13714a68b4b88fd353e43719fda0c0d31 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/754818 CI-Result: Cloud Build <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
julieqiu
changed the title
Refresh now like godoc.org Refresh now like godoc.org
|
I'm just wondering, why the README is not being updated with the version push like GitHub.com/1234/[email protected] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What did you do?
View documents on
pkg.go.dev.What did you expect to see?
Latest documents.
What did you see instead?
Out-of-date documents, even its counterpart on
godoc.orgwas updated a few days ago.The text was updated successfully, but these errors were encountered: