Skip to content

os/exec: revert macOS __fork fix before point release [1.19 backport] #57690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jan 8, 2023 · 2 comments
Closed

os/exec: revert macOS __fork fix before point release [1.19 backport] #57690

gopherbot opened this issue Jan 8, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.19.5

Comments

@gopherbot
Copy link
Contributor

@rsc requested issue #57688 to be considered for backport to the next 1.19 minor release.

@gopherbot please backport WTF
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 8, 2023
@gopherbot gopherbot mentioned this issue Jan 8, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.5 milestone Jan 8, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/461115 mentions this issue: [release-branch.go1.19] runtime: revert "call __fork instead of fork on darwin"

gopherbot pushed a commit that referenced this issue Jan 9, 2023
@rsc
[release-branch.go1.19] runtime: revert "call __fork instead of fork …
7d06dd6 
…on darwin"

A recent comment on #57263 reports an unexplained crash in a cgo program
that is fixed by reverting the __fork fix. We don't have any viable fix for the
os/exec bug at this point, so give up on a fix for the January point releases.

This reverts CL 459178 (commit 91bc4cd).

Fixes #57690.

Change-Id: Ieb38d9bc7f967e9a726429eab2ea515d5ca0847f
Reviewed-on: https://go-review.googlesource.com/c/go/+/461115
Run-TryBot: Russ Cox <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 7d06dd6 to release-branch.go1.19.

@dmitshur dmitshur mentioned this issue Jan 10, 2023
Closed
@golang golang locked and limited conversation to collaborators Jan 9, 2024
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot