x/tools/internal/gcimporter: TestImportTypeparamTests depends on GOROOT/test/typeparam

[hyangah]

https://github.com/golang/tools/blob/73d6794ebbd4a16f44bdf838c2aa5fe79a63830d/internal/gcimporter/gcimporter_test.go#L197

I don't know if this test is still relevant. But I noticed that this test tries to read the directory runtime.GOROOT()/test/typeparam.
However, this test/typeparam directory does not exist in the toolchain module downloaded from the module proxy.

For example, inspect https://proxy.golang.org/golang.org/toolchain/@v/v0.0.1-go1.22.0.darwin-amd64.zip

So, if the test runs with the toolchain downloaded from the module proxy (with toolchain switch), that can cause test failure.

[gabyhelp]

Related Issues and Documentation

• go/internal/gcimporter: `lookupGorootExport` should use the `go` command from `build.Default.GOROOT` #59598 (closed)
• go/internal/srcimporter: TestImportedTypes depends on the network, breaks several builds #30760 (closed)
• x/tools/go/gcexportdata: can't import package from pkg/mod #52269
• x/tools/internal/gcimporter: TestImportTypeparamTests failures #57127 (closed)
• x/tools/internal/gcimporter: TestImportTypeparamTests failures #57826 (closed)
• x/tools/internal/gcimporter: TestIssueAliases is failing on x_tools-gotip-linux-amd64-aliastypeparams builder #69627 (closed)
• go/internal/gcimporter: skip TestImportTypeparamTests if GOROOT/test is missing
• x/tools/go/packages: TestLoadImportsGraph failure with custom GOCACHE #29445 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[hyangah]

Gaby found CL 504117 added for go/internal/gcimporter: skip TestImportTypeparamTests if GOROOT/test is missing. x/tools/internal/gcimporter needs it too.

[gopherbot]

Change https://go.dev/cl/622896 mentions this issue: all: fix x/tools tests that fail with a go1.23.1 go.work file