Skip to content

x/tools/gopls/internal/test/marker: test holds open temp files after it has finished (windows) #71544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Feb 3, 2025 · 4 comments
Open

x/tools/gopls/internal/test/marker: test holds open temp files after it has finished (windows) #71544

gopherbot opened this issue Feb 3, 2025 · 4 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/references\\issue59851.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/references\issue59851.txt
=== PAUSE Test/references\issue59851.txt
=== CONT  Test/references\issue59851.txt
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\b\s\w\ir\x\t\Testreferencesissue59851.txt4078840582\001\work: The process cannot access the file because it is being used by another process.
--- FAIL: Test/references\issue59851.txt (36.42s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/references\\issue59851.txt"
2025-02-03 16:44 x_tools-go1.22-windows-amd64-longtest tools@269282df release-branch.go1.22@0cc45e7c x/tools/gopls/internal/test/marker.Test/references\issue59851.txt (log) 
=== RUN   Test/references\issue59851.txt
=== PAUSE Test/references\issue59851.txt
=== CONT  Test/references\issue59851.txt
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\b\s\w\ir\x\t\Testreferencesissue59851.txt4078840582\001\work: The process cannot access the file because it is being used by another process.
--- FAIL: Test/references\issue59851.txt (36.42s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 3, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2025
@adonovan adonovan changed the title x/tools/gopls/internal/test/marker: Test/references\issue59851.txt failures x/tools/gopls/internal/test/marker: test holds open temp files after it has finished (windows) Feb 4, 2025
@adonovan
Copy link
Member

adonovan commented Feb 4, 2025

Related:

These problems seem to predate x/telemetry, so I doubt the telemetry subprocess can be (solely) to blame.

@adonovan adonovan self-assigned this Feb 7, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/647516 mentions this issue: go/packages: add test that go list closes file handles

@jba jba modified the milestones: Unreleased, gopls/v0.18.1 Feb 13, 2025
fredbi added a commit to fredbi/analysis that referenced this issue Mar 11, 2025
@fredbi
Relinting (2)
accb348 
* addressed linting issues, especially those related to non-wrapping
  errors: refactored all calls to fmt.Errorf()
* fixes go-openapi#114: unfortunate copy paste typo in mixin.go

* test: worked around go issue on windows: golang/go#71544

Signed-off-by: Frederic BIDON <[email protected]>
fredbi added a commit to go-openapi/analysis that referenced this issue Mar 11, 2025
@fredbi
Relinting (2)
dc87465 
* addressed linting issues, especially those related to non-wrapping
  errors: refactored all calls to fmt.Errorf()
* fixes #114: unfortunate copy paste typo in mixin.go

* test: worked around go issue on windows: golang/go#71544

Signed-off-by: Frederic BIDON <[email protected]>
@adonovan adonovan modified the milestones: gopls/v0.19.0, gopls/v0.20.0 Apr 18, 2025
gopherbot pushed a commit to golang/tools that referenced this issue Apr 23, 2025
@adonovan @gopherbot
go/packages: add test that go list closes file handles
cd18362 
Updates golang/go#71544

Change-Id: I349f97a0c5eb679115ea251d37dbd56042c7679b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/647516
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Commit-Queue: Alan Donovan <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/667857 mentions this issue: go/packages: add variant of TestRmdirAfterGoList without gocommand

gopherbot pushed a commit to golang/tools that referenced this issue Apr 24, 2025
@adonovan @gopherbot
go/packages: add variant of TestRmdirAfterGoList without gocommand
2f3d4ad 
This CL adds the test in the first patchset of CL 647516, which
executes go list directly, thus providing a control for the
substantial gocommand wrapper package.

Updates golang/go#71544
Updates golang/go#73481

Change-Id: I3dbc91cb1144bd5cafbd438817a17abda1c811ae
Reviewed-on: https://go-review.googlesource.com/c/tools/+/667857
Auto-Submit: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Sam Thanawalla <[email protected]>
@adonovan adonovan modified the milestones: gopls/v0.20.0, gopls/backlog Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: No status
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@adonovan @gopherbot @jba @findleyr