Skip to content

net/http: fix minor typos in Request godoc #27649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

net/http: fix minor typos in Request godoc #27649

wants to merge 1 commit into from

Conversation

ivy
Copy link
Contributor

@ivy ivy commented Sep 13, 2018

Fixes missing commas where it wasn't immediately apparent whether
"requests" was being used as a verb or a noun.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 13, 2018
Fixes missing commas where it wasn't immediately apparent whether
"requests" was being used as a verb or a noun.
@gopherbot
Copy link
Contributor

This PR (HEAD: 1becf6f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/135135 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5137:

Patch Set 1: Code-Review+2

Thank you Ivy for the fixes and welcome to Go! LGTM


Please don’t reply on this GitHub thread. Visit golang.org/cl/135135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/135135 has been merged.

@gopherbot gopherbot closed this Sep 18, 2018
westonsteimel pushed a commit to westonsteimel/go that referenced this pull request Sep 18, 2018
Fixes missing commas where it wasn't immediately apparent whether
"requests" was being used as a verb or a noun.

Change-Id: Ic8c99b4f46475f40a6160d26a3cd11c215940dd5
GitHub-Last-Rev: 1becf6f
GitHub-Pull-Request: golang#27649
Reviewed-on: https://go-review.googlesource.com/135135
Reviewed-by: Emmanuel Odeke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants