Skip to content

doc/play: match the hello world snippet in x/website #35123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc/play: match the hello world snippet in x/website #35123

wants to merge 1 commit into from

Conversation

rhnvrm
Copy link
Contributor

@rhnvrm rhnvrm commented Oct 23, 2019

Fixes #35099

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 23, 2019
@rhnvrm
Copy link
Contributor Author

rhnvrm commented Oct 23, 2019

cc @dmitshur

@gopherbot
Copy link
Contributor

This PR (HEAD: 12973bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202998 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1: Run-TryBot+1 Code-Review+2

LGTM. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202998.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9e613286

Please don’t reply on this GitHub thread. Visit golang.org/cl/202998.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202998.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/202998 has been merged.

@gopherbot gopherbot closed this Oct 23, 2019
gopherbot pushed a commit that referenced this pull request Oct 23, 2019
@rhnvrm @dmitshur
doc/play: match the hello world snippet in x/website
20bba86 
Fixes #35099

Change-Id: Ieaf3174540087bd20443b38703ef88d9f9638052
GitHub-Last-Rev: 12973bc
GitHub-Pull-Request: #35123
Reviewed-on: https://go-review.googlesource.com/c/go/+/202998
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/website: golang.org homepage has two different Hello worlds, one is not gofmt-ed
3 participants
@rhnvrm @gopherbot @googlebot