net: never probe IPv4 map support on DragonFly BSD, OpenBSD #45243
Conversation
google-cla
bot
added
the
cla: yes
|
@sthen fyi |
|
This PR (HEAD: 6b9872e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/304870 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Josh Rickmar: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Josh Rickmar: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
DragonFly BSD and OpenBSD do not implement mapping IPv4 addresses to the IPv6 address space, and a runtime check can be avoided. As the IP stack capabilities probe was only being called from supportsIPv4map to check for this support, the OS-specific handling can be added to this function rather than continuing to run the probe.
jrick
changed the title
|
This PR (HEAD: 7eb6718) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/304870 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Go Bot: Patch Set 2: SlowBots beginning. Status page: https://farmer.golang.org/try?commit=7531440e Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Go Bot: Patch Set 2: TryBot-Result+1 SlowBots are happy. SlowBot builds that ran:
Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
|
Message from Ian Lance Taylor: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304870. |
DragonFly BSD and OpenBSD do not implement mapping IPv4 addresses to the IPv6 address space, and a runtime check can be avoided. As the IP stack capabilities probe was only being called from supportsIPv4map to check for this support, the OS-specific handling can be added to this function rather than continuing to run the probe. Change-Id: I5800c197b1be502a6efa79e3edd6356bde8637fb GitHub-Last-Rev: 7eb6718 GitHub-Pull-Request: #45243 Reviewed-on: https://go-review.googlesource.com/c/go/+/304870 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Tobias Klauser <[email protected]>
|
This PR is being closed because golang.org/cl/304870 has been merged. |
DragonFly BSD and OpenBSD do not implement mapping IPv4 addresses to
the IPv6 address space, and a runtime check can be avoided.
As the IP stack capabilities probe was only being called from
supportsIPv4map to check for this support, the OS-specific handling
can be added to this function rather than continuing to run the probe.