mime: support reading shared mime-info database on unix systems #45271

Jacalz · 2021-03-28T12:12:38Z

This adds support for reading the FreeDesktop Shared MIME-info Database on Unix systems, if it exists.
It should make lookups work on systems where the mime.types files are not present and
should lead to better mimetype lookup in general. If the shared mimetype database does not exist,
we will fall back to reading mime.types files in common locations.

Related to a bug on Solus bugtracker: https://dev.getsol.us/T9394
This change makes the mime package work on Solus.

google-cla · 2021-03-28T12:12:42Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Jacalz · 2021-03-28T12:16:46Z

@googlebot I signed it!

gopherbot · 2021-03-28T12:19:31Z

This PR (HEAD: dcda643) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-28T12:23:06Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-28T23:02:35Z

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-28T23:04:30Z

Message from Go Bot:

Patch Set 1:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=0a3781ab

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-29T15:43:00Z

This PR (HEAD: 274c055) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-29T15:45:26Z

This PR (HEAD: cf3f8f0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This adds support for reading the FreeDesktop Shared MIME-info Database on Unix systems, if it exists. It should make lookups work on systems where the mime.types files are not present and should lead to better mimetype lookup in general. If the shared mimetype database does not exist, we will fall back to reading mime.types files in common locations. Related to a bug on Solus bugtracker: https://dev.getsol.us/T9394 This change makes the mime package work on Solus.

gopherbot · 2021-03-29T16:17:18Z

Message from Jacob Alz:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-29T18:09:59Z

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-30T17:45:40Z

This PR (HEAD: 1b573c2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-30T18:18:09Z

Message from Jacob Alz:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-30T21:01:39Z

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-04T15:39:26Z

This PR (HEAD: cb06878) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-04T15:41:20Z

Message from Jacob Alz:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-05T18:21:47Z

Message from Ian Lance Taylor:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-07T15:32:57Z

This PR (HEAD: 01d5637) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-07T15:37:11Z

Message from Jacob Alz:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-07T22:57:57Z

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-07T22:59:50Z

Message from Go Bot:

Patch Set 8:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=64ebb499

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-07T23:05:56Z

Message from Go Bot:

Patch Set 8:

Build is still in progress...
This change failed on windows-amd64-2016:
See https://storage.googleapis.com/go-build-log/64ebb499/windows-amd64-2016_e8c5ebb7.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-07T23:07:49Z

Message from Ian Lance Taylor:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-09T14:58:05Z

This PR (HEAD: d5fbe8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305230 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-09T15:00:11Z

Message from Jacob Alz:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-09T15:49:59Z

Message from Ian Lance Taylor:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-09T15:49:59Z

Message from Go Bot:

Patch Set 9:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=1e166e94

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-10T04:20:31Z

Message from Go Bot:

Patch Set 9:

Build is still in progress...
This change failed on darwin-amd64-10_14:
See https://storage.googleapis.com/go-build-log/1e166e94/darwin-amd64-10_14_03e73fca.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-12T14:49:33Z

Message from Jacob Alz:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-12T17:08:27Z

Message from Ian Lance Taylor:

Patch Set 9: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-12T18:07:36Z

Message from Tobias Klauser:

Patch Set 9: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-04-12T20:41:30Z

Message from Go Bot:

Patch Set 9: TryBot-Result-1

1 of 25 SlowBots failed:
Failed on darwin-amd64-10_14: https://storage.googleapis.com/go-build-log/1e166e94/darwin-amd64-10_14_03e73fca.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

SlowBot builds that ran:

darwin-amd64-10_14
dragonfly-amd64
freebsd-amd64-12_0
openbsd-amd64-68

Please don’t reply on this GitHub thread. Visit golang.org/cl/305230.
After addressing review feedback, remember to publish your drafts!

This adds support for reading the FreeDesktop Shared MIME-info Database on Unix systems, if it exists. It should make lookups work on systems where the mime.types files are not present and should lead to better mimetype lookup in general. If the shared mimetype database does not exist, we will fall back to reading mime.types files in common locations. Related to a bug on Solus bugtracker: https://dev.getsol.us/T9394 This change makes the mime package work on Solus. Change-Id: If330c22ffe523bf31f7f10807a54fc8858517055 GitHub-Last-Rev: d5fbe8c GitHub-Pull-Request: #45271 Reviewed-on: https://go-review.googlesource.com/c/go/+/305230 Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Tobias Klauser <[email protected]>

gopherbot · 2021-04-12T21:08:10Z

This PR is being closed because golang.org/cl/305230 has been merged.

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 28, 2021

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 28, 2021

Jacalz changed the title ~~src/mime: Use os-generated mimetypes on unix systems~~ mime: support reading shared mime-info database on unix systems Mar 29, 2021

Fix possible panic on short slices

1b573c2

Add test for both format parsers

cb06878

Rework the tests to make a bit more sense

01d5637

Add in missing build contraint

d5fbe8c

gopherbot closed this Apr 12, 2021

Jacalz deleted the mimetypes branch April 14, 2021 06:34

francislavoie mentioned this pull request Aug 17, 2021

Deriving mime type inconsistent with Go 1.17 caddyserver/caddy#4287

Closed

mime: support reading shared mime-info database on unix systems #45271

mime: support reading shared mime-info database on unix systems #45271

Uh oh!

Conversation

Jacalz commented Mar 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Mar 28, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Jacalz commented Mar 28, 2021

Uh oh!

gopherbot commented Mar 28, 2021

Uh oh!

gopherbot commented Mar 28, 2021

Uh oh!

gopherbot commented Mar 28, 2021

Uh oh!

gopherbot commented Mar 28, 2021

Uh oh!

gopherbot commented Mar 29, 2021

Uh oh!

gopherbot commented Mar 29, 2021

Uh oh!

gopherbot commented Mar 29, 2021

Uh oh!

gopherbot commented Mar 29, 2021

Uh oh!

gopherbot commented Mar 30, 2021

Uh oh!

gopherbot commented Mar 30, 2021

Uh oh!

gopherbot commented Mar 30, 2021

Uh oh!

gopherbot commented Apr 4, 2021

Uh oh!

gopherbot commented Apr 4, 2021

Uh oh!

gopherbot commented Apr 5, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 7, 2021

Uh oh!

gopherbot commented Apr 9, 2021

Uh oh!

gopherbot commented Apr 9, 2021

Uh oh!

gopherbot commented Apr 9, 2021

Uh oh!

gopherbot commented Apr 9, 2021

Uh oh!

gopherbot commented Apr 10, 2021

Uh oh!

gopherbot commented Apr 12, 2021

Uh oh!

gopherbot commented Apr 12, 2021

Uh oh!

gopherbot commented Apr 12, 2021

Uh oh!

gopherbot commented Apr 12, 2021

Uh oh!

gopherbot commented Apr 12, 2021

Uh oh!

Uh oh!

Jacalz commented Mar 28, 2021 •

edited

Loading