cmd/go/internal/web: improve IP check testing on ipv6 env #48850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

awen09 wants to merge 1 commit into golang:master from awen09:bugfix/http_test_ip_check

+10 −2

awen09 commented Oct 7, 2021

The existing implementation lacks consideration of running test on a
machine which has ipv6 address but no ipv4 address. Use net.IP.IsLoopback
and net.IP.IsUnspecified instead of hardcoded addresses.

Fixes: #48575

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.


          cmd/go/internal/web: improve IP check testing on ipv6 env

fc45adb

The existing implementation lacks consideration of running test on a
machine which has ipv6 address but no ipv4 address. Use net.IP.IsLoopback
and net.IP.IsUnspecified instead of hardcoded addresses.

Fixes: golang#48575

google-cla bot added the cla: yes label

Contributor

gopherbot commented Oct 7, 2021

This PR (HEAD: fc45adb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/354609 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Jay Conrod:

Patch Set 1: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Bryan C. Mills:

Patch Set 2: Patch Set 1 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354609.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/go/internal/web: improve IP check testing on ipv6 env

4ab3c10

The existing implementation lacks consideration of running test on a
machine which has ipv6 address but no ipv4 address. Use net.IP.IsLoopback
and net.IP.IsUnspecified instead of hardcoded addresses.

Fixes: #48575

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Change-Id: I9c3c26d2ba13c7a24065751b59a1e002098ed654
GitHub-Last-Rev: fc45adb
GitHub-Pull-Request: #48850
Reviewed-on: https://go-review.googlesource.com/c/go/+/354609
Reviewed-by: Bryan C. Mills <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Jay Conrod <[email protected]>

Contributor

gopherbot commented Oct 7, 2021

This PR is being closed because golang.org/cl/354609 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels