-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/dist: avoid CPU underutilization starting from GOMAXPROCS=2 runtime #65703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 5624a70) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 1: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
5624a70
to
cc5f615
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
This PR (HEAD: cc5f615) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Gopher Robot: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 2: -Run-TryBot (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
This PR (HEAD: 94e7973) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from qiulaidongfeng: Patch Set 4: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-02T04:34:59Z","revision":"1d0ca531607d0036919c2c36687d154a1b899281"} Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
This PR (HEAD: d1db60f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from qiulaidongfeng: Patch Set 5: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-13T09:37:06Z","revision":"ecdffe1031022dc6f7f389dfedefee5ab3f9b8fb"} Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
This PR (HEAD: a9f5193) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from qiulaidongfeng: Patch Set 6: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-14T13:30:00Z","revision":"02d314284b962c1c34dccaaa11ecbb371ab70fd0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Fixes golang#65164 Change-Id: Ia10952f50a3c2a7868e30dcdba333927947b3ac3
This PR (HEAD: 18cffb7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/563916. Important tips:
|
Message from qiulaidongfeng: Patch Set 7: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-16T03:44:29Z","revision":"ecc48dd43df6bfabe77f29e1be351ef27f161be0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 7: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from Keith Randall: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from David Chase: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
Message from qiulaidongfeng: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/563916. |
This CL is doing now is: change maxbg to increase test parallelism. adjust test sequence. This CL speeds up the go tool dist test, most of the speed up is due to the fact that the three time-consuming tests cmd/internal/testdir and API check and runtime/race can be done in parallel with the GOMAXPROCS=2 runtime on a machine with enough CPU cores. In windows with an 8-core 16-thread CPU, this CL can complete all other tests before GOMAXPROCS=2 runtime -cpu=1,2,4 -quick completes. Fixes #65164 Change-Id: I56ed7031d58be3bece9f975bfc73e5c834d0a4fa GitHub-Last-Rev: 18cffb7 GitHub-Pull-Request: #65703 Reviewed-on: https://go-review.googlesource.com/c/go/+/563916 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/563916 has been merged. |
This CL is doing now is:
change maxbg to increase test parallelism.
adjust test sequence.
This CL speeds up the go tool dist test,
most of the speed up is due to the fact that the
three time-consuming tests
cmd/internal/testdir and API check and runtime/race
can be done in parallel with the GOMAXPROCS=2 runtime
on a machine with enough CPU cores.
In windows with an 8-core 16-thread CPU,
this CL can complete all other tests before
GOMAXPROCS=2 runtime -cpu=1,2,4 -quick completes.
Fixes #65164