runtime, internal/syscall/unix: mark getrandom vDSO as non-escaping #69719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mateusz834 wants to merge 1 commit into golang:master from mateusz834:vdso-getrandom-noescape

Member

mateusz834 commented Sep 30, 2024 •

edited

Loading

Updates #66779
Updates #69577


          runtime, internal/syscall/unix: mark getrandom vDSO as non-escaping

1cea46d

Updates golang#66779

Change-Id: Iaa3eda4309bb1e8c28136dd048479e7269f4c189

Contributor

gopherbot commented Sep 30, 2024

This PR (HEAD: 1cea46d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/616696.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Sep 30, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Mateusz Poliwczak:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-30T17:54:00Z","revision":"5e61d60d35a27df172aa9d8e752fb056ae03b4fc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Filippo Valsorda:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Filippo Valsorda:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 2 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-30T18:01:12Z","revision":"90852b3725e00b919fc016ec4a2a0487cab677c1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Mateusz Poliwczak:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-30T18:01:50Z","revision":"90852b3725e00b919fc016ec4a2a0487cab677c1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2024

Message from Michael Pratt:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/616696.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          runtime, internal/syscall/unix: mark getrandom vDSO as non-escaping

ba10a38

Updates #66779
Updates #69577

Change-Id: I0dea5a30aab87aaa443e7e6646c1d07aa865ac1c
GitHub-Last-Rev: 1cea46d
GitHub-Pull-Request: #69719
Reviewed-on: https://go-review.googlesource.com/c/go/+/616696
LUCI-TryBot-Result: Go LUCI <[email protected]>
Commit-Queue: Ian Lance Taylor <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>

Contributor

gopherbot commented Sep 30, 2024

This PR is being closed because golang.org/cl/616696 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet