net: avoid using Windows' TransmitFile on non-server machines #73758

shibijm · 2025-05-18T08:54:30Z

Windows API's TransmitFile function is limited to two concurrent
operations on workstation and client versions of Windows. This change
modifies the net.sendFile function to perform no work in such cases
so that TransmitFile is avoided.

Fixes #73746

google-cla · 2025-05-18T08:54:34Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2025-05-18T08:58:09Z

This PR (HEAD: 10993f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-18T09:04:43Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T09:04:43Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T09:10:54Z

Message from Shibi J M:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T09:58:23Z

Message from qiu laidongfeng2:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T09:58:23Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-18T09:49:13Z","revision":"940c666432fd0e76d880f667fd24631810b1bb25"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T10:10:16Z

Message from qiu laidongfeng2:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T10:10:16Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

go on master (change 673855)

To reproduce, try gomote repro 8714542394429195601.

Additional links for debugging:

go tool dist test -json output [shard 2]

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T10:10:16Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-18T10:10:23Z

This PR (HEAD: 4be37a2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-18T11:06:56Z

This PR (HEAD: 02abfaf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-19T07:39:46Z

Message from Emmanuel Odeke:

Patch Set 4: Commit-Queue+1 Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T07:46:21Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-19T07:34:09Z","revision":"b0dc2fd46608c17deba31cf8b66e5a65039fdf7d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T07:46:21Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T08:14:07Z

Message from Emmanuel Odeke:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T08:14:08Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T08:14:09Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T09:13:49Z

This PR (HEAD: 39e9bfe) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-19T09:20:23Z

Message from Shibi J M:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T18:42:43Z

Message from Damien Neil:

Patch Set 5: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T18:42:44Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-19T18:31:35Z","revision":"8a14f678c6334245065cf15f65f8d13ca19e249e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T19:01:27Z

Message from Damien Neil:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T19:01:28Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T19:01:28Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T20:20:57Z

This PR (HEAD: 18e1d2f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-19T20:27:15Z

Message from Shibi J M:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T20:52:00Z

Message from Damien Neil:

Patch Set 6: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T20:57:57Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-19T20:45:19Z","revision":"11c37f395845343c553aa71108843ef137935531"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T21:03:55Z

Message from Damien Neil:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T21:03:56Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 673855) / tools on master (commit 87f67c8)

To reproduce, try gomote repro 8714410521749788433.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T21:03:56Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T21:16:03Z

Message from Shibi J M:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-19T22:12:21Z

Message from Damien Neil:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T03:59:19Z

This PR (HEAD: 315ddc0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/673855.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T04:12:03Z

Message from Shibi J M:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T09:36:24Z

Message from Alex Brainman:

Patch Set 7: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T09:43:15Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-20T09:30:11Z","revision":"6fe2b44ada131b51a8e931d910a3f864e39cab58"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T10:04:14Z

Message from Alex Brainman:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T10:04:14Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T10:04:15Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T10:04:17Z

Message from Quim Muntal:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T18:04:58Z

Message from David Chase:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T18:04:58Z

Message from Damien Neil:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

Windows API's TransmitFile function is limited to two concurrent operations on workstation and client versions of Windows. This change modifies the net.sendFile function to perform no work in such cases so that TransmitFile is avoided. Fixes #73746 Change-Id: Iba70d5d2758bf986e80c78254c8e9e10b39bb368 GitHub-Last-Rev: 315ddc0 GitHub-Pull-Request: #73758 Reviewed-on: https://go-review.googlesource.com/c/go/+/673855 Reviewed-by: Alex Brainman <[email protected]> Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Quim Muntal <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Damien Neil <[email protected]>

gopherbot · 2025-05-20T18:11:27Z

Message from Damien Neil:

Patch Set 7: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/673855.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T18:17:57Z

This PR is being closed because golang.org/cl/673855 has been merged.

shibijm force-pushed the bypass-limited-transmitfile branch from 3f6b8ea to 10993f4 Compare May 18, 2025 08:57

shibijm force-pushed the bypass-limited-transmitfile branch from 10993f4 to 4be37a2 Compare May 18, 2025 10:08

shibijm force-pushed the bypass-limited-transmitfile branch from 4be37a2 to 02abfaf Compare May 18, 2025 11:01

shibijm force-pushed the bypass-limited-transmitfile branch 2 times, most recently from 8cdaeec to 39e9bfe Compare May 19, 2025 09:08

shibijm changed the title ~~net: bypass concurrency-limited WinAPI TransmitFile function~~ net: avoid using Windows' TransmitFile on non-server machines May 19, 2025

shibijm force-pushed the bypass-limited-transmitfile branch from 39e9bfe to 18e1d2f Compare May 19, 2025 20:19

net: avoid using Windows' TransmitFile on non-server machines

315ddc0

shibijm force-pushed the bypass-limited-transmitfile branch from 18e1d2f to 315ddc0 Compare May 20, 2025 03:53

gopherbot closed this May 20, 2025

net: avoid using Windows' TransmitFile on non-server machines #73758

net: avoid using Windows' TransmitFile on non-server machines #73758

Conversation

shibijm commented May 18, 2025 • edited Loading

google-cla bot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 18, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 19, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

gopherbot commented May 20, 2025

shibijm commented May 18, 2025 •

edited

Loading