Skip to content

Azure AD package #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hexadecy opened this issue Nov 22, 2017 · 4 comments
Closed

Azure AD package #257

hexadecy opened this issue Nov 22, 2017 · 4 comments
Assignees

Comments

@hexadecy
Copy link

More useful than the Microsoft package.

package azure

import (
	"golang.org/x/oauth2"
)

// Endpoint is Azure AD OAuth 2.0 endpoint.
var Endpoint = oauth2.Endpoint{
	AuthURL:  "https://login.microsoftonline.com/common/oauth2/v2.0/authorize",
	TokenURL: "https://login.microsoftonline.com/common/oauth2/v2.0/token",
}
@rakyll
Copy link
Contributor

rakyll commented Nov 22, 2017

I will create a change, thanks.

@rakyll rakyll self-assigned this Nov 22, 2017
@rakyll
Copy link
Contributor

rakyll commented Nov 22, 2017

I have one question actually before sending out the change. How does this differ from the microsoft package? Do Azure services require a different endpoint?

@hexadecy
Copy link
Author

hexadecy commented Nov 22, 2017

https://developer.microsoft.com/en-us/graph/docs/concepts/auth_overview
You must/should use Azure AD for Microsoft Graph or Office 365 REST API, more work related

Login live is more for personnal Outlook Account ect...

@hexadecy hexadecy reopened this Nov 22, 2017
@rumyantseva
Copy link
Contributor

Hello!

Currently, I'm working on a project where we use Azure AD OAuth2.
I noticed, that the endpoints are a bit more complicated than just https://login.microsoftonline.com/common/.... Sometimes instead of common, you might need other tenants (for more information see the documentation).

I suggested my changes here: https://go-review.googlesource.com/#/c/oauth2/+/82315/
I hope, this contribution might be useful.

Thank you.

gopherbot pushed a commit that referenced this issue Dec 11, 2017
Fixes #257.

Change-Id: I0fa087fd921256f03a0cd62a8ab559c5c63f4d0f
Reviewed-on: https://go-review.googlesource.com/79397
Reviewed-by: Brad Fitzpatrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants