Skip to content

Commit 658a7a4

Browse files
committed
content/static,internal/fetch/dochtml: expand all nav elements by default
We’ve received feedback that a fully-collapsed side nav prevents users from being able to see package structure at a glance. Expand all functions and types by default. Also updates CSS for the side nav to not show a scroll bar if the content doesn’t overflow. Updates golang/go#40612 Fixes golang/go#40715 Change-Id: I22049e394b8705316e1ebe1cb9691c6317c61c5b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/248183 Run-TryBot: Andrew Bonventre <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Jamal Carvalho <[email protected]>
1 parent f245a6b commit 658a7a4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

content/static/css/sidenav.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
display: block;
114114
max-height: calc(100vh - var(--header-height));
115115
overflow-x: hidden;
116-
overflow-y: scroll;
116+
overflow-y: auto;
117117
padding-top: 1rem;
118118
padding-left: 0.25rem;
119119
position: sticky;

internal/fetch/dochtml/template.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ var htmlPackage = template.Must(template.New("package").Funcs(
8989
9090
{{if .Funcs}}
9191
<li class="DocNav-functions" role="none">
92-
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="false" aria-level="1" aria-owns="nav-group-functions" tabindex="-1">Functions</span>
92+
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="true" aria-level="1" aria-owns="nav-group-functions" tabindex="-1">Functions</span>
9393
<ul role="group" id="nav-group-functions">
9494
{{range .Funcs}}
9595
<li role="none">
@@ -102,15 +102,15 @@ var htmlPackage = template.Must(template.New("package").Funcs(
102102
103103
{{if .Types}}
104104
<li class="DocNav-types" role="none">
105-
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="false" aria-level="1" aria-owns="nav-group-types" tabindex="-1">Types</span>
105+
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="true" aria-level="1" aria-owns="nav-group-types" tabindex="-1">Types</span>
106106
<ul role="group" id="nav-group-types">
107107
{{range .Types}}
108108
{{$tname := .Name}}
109109
<li role="none">
110110
{{if or .Funcs .Methods}}
111111
{{$navgroupname := (printf "nav.group.%s" $tname)}}
112112
{{$navgroupid := (safe_id $navgroupname)}}
113-
<a class="DocNav-groupLabel" href="#{{$tname}}" role="treeitem" aria-expanded="false" aria-level="2" data-aria-owns="{{$navgroupid}}" tabindex="-1">type {{$tname}}</a>
113+
<a class="DocNav-groupLabel" href="#{{$tname}}" role="treeitem" aria-expanded="true" aria-level="2" data-aria-owns="{{$navgroupid}}" tabindex="-1">type {{$tname}}</a>
114114
<ul role="group" id="{{$navgroupid}}">
115115
{{range .Funcs}}
116116
<li role="none">

0 commit comments

Comments
 (0)