Skip to content

Disable Go Companion when using a non-prerelease version of vscode-go #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
firelizzard18 opened this issue Jan 6, 2025 · 2 comments · Fixed by firelizzard18/exp-vscode-go#3
Closed

Disable Go Companion when using a non-prerelease version of vscode-go #3651

firelizzard18 opened this issue Jan 6, 2025 · 2 comments · Fixed by firelizzard18/exp-vscode-go#3
Assignees
@firelizzard18
Labels
Go Companion Issues relating to the Go Companion extension
Milestone
vscode-go/backlog

Comments

@firelizzard18
Copy link
Contributor

Suppress Go Companion's duplicate features (test explorer, code lenses) when using a non-prerelease version of vscode-go to improve the developer experience as discussed on #3649. This should show the user a notification like the vscode-go experiment does so the user realizes that Go Companion is (mostly) disabled.
@firelizzard18 firelizzard18 added the Go Companion Issues relating to the Go Companion extension label Jan 6, 2025
@firelizzard18 firelizzard18 self-assigned this Jan 6, 2025
@gopherbot gopherbot added this to the Untriaged milestone Jan 6, 2025
@findleyr findleyr modified the milestones: Untriaged, vscode-go/backlog Jan 16, 2025
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/653115 mentions this issue: src/extensionAPI: expose isPreview

@firelizzard18 firelizzard18 moved this to In Progress in Testing UI Renewal Feb 26, 2025
@firelizzard18 firelizzard18 mentioned this issue Feb 26, 2025
Merged
gopherbot pushed a commit that referenced this issue Mar 5, 2025
@firelizzard18 @h9jiang
src/extensionAPI: expose isPreview
3a91503 
Expose isPreview - whether the extension is running in preview mode
(e.g. a prerelease version) - in the extension API.

Also, fix a typo.

Updates #3651.

Change-Id: I991d3118d2f7786facb43d8252bf3e4fb294118d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/653115
Reviewed-by: Hongxiang Jiang <[email protected]>
kokoro-CI: kokoro <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Madeline Kalil <[email protected]>
@firelizzard18
Copy link
Contributor Author

firelizzard18 commented Mar 26, 2025 •
edited
Loading

This feature is ready but it won't work as expected until the next release (which will include 653115)

@firelizzard18 firelizzard18 moved this from In Progress to Done in Testing UI Renewal Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firelizzard18 firelizzard18

Labels
Go Companion Issues relating to the Go Companion extension
Projects
Testing UI Renewal
Status: Done
Milestone
vscode-go/backlog
Development

Successfully merging a pull request may close this issue.

Enable test explorer conditionally based on Go extension firelizzard18/exp-vscode-go
3 participants
@firelizzard18 @gopherbot @findleyr