Skip to content

False positives coming from deadcode #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryboe opened this issue Jun 17, 2018 · 2 comments
Closed

False positives coming from deadcode #116

ryboe opened this issue Jun 17, 2018 · 2 comments
Labels
false positive An error is reported when one does not exist

Comments

@ryboe
Copy link
Contributor

ryboe commented Jun 17, 2018 •
edited
Loading

deadcode has a serious bug: It incorrectly flags any test in package main as unused. It's causing golangci-lint to report a bunch of false positives in my codebase at work. gometalinter.v2 doesn't have this problem and I'm unsure why.

This fix was submitted in December 2017, but it hasn't been reviewed or merged, which tells me that @remyoudompheng isn't really maintaining it.

Until the bug is fixed upstream, it would be nice if golangci-lint either 1) suppressed the false positive internally, 2) provided guidance about how to suppress the false positive in the README, or 3) forked and fixed deadcode.
@jirfag
Copy link
Contributor

jirfag commented Jun 17, 2018

thank you for reporting

@jirfag jirfag added the false positive An error is reported when one does not exist label Jun 17, 2018
golangci pushed a commit that referenced this issue Jun 28, 2018
@jirfag
Fix #109, #116, #131: don't report in deadcode about unused test func…
001f788 
…tions in main package
jirfag added a commit that referenced this issue Jun 28, 2018
@jirfag
Fix #109, #116, #131: don't report in deadcode about unused test func…
88ebabc 
…tions in main package
@jirfag
Copy link
Contributor

jirfag commented Jun 28, 2018

Fixed it

@jirfag jirfag closed this as completed Jun 28, 2018
@ryboe ryboe mentioned this issue Jun 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false positive An error is reported when one does not exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryboe @jirfag