-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add unparam linter? #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
linter: new
Support new linter
Comments
golangci
pushed a commit
that referenced
this issue
Jun 30, 2018
1. Support unparam linter and fix found issues 2. Replace forked mvdan.cc/lint and mvdan.cc/interfacer with the upstream ones 3. Minimize forked megacheck: move the most of it's code to this repo 4. Use golang.org/x/tools/go/ssa import path instead of custom fork paths 5. In golang.org/x/tools/go/{ssa,callgraph} use changed code from honnef.co/go/tools 6. Add megacheck.check-unexported option: it found some issues in the repo, fixed them all
golangci
pushed a commit
that referenced
this issue
Jun 30, 2018
1. Support unparam linter and fix found issues 2. Replace forked mvdan.cc/lint and mvdan.cc/interfacer with the upstream ones 3. Minimize forked megacheck: move the most of it's code to this repo 4. Use golang.org/x/tools/go/ssa import path instead of custom fork paths 5. In golang.org/x/tools/go/{ssa,callgraph} use changed code from honnef.co/go/tools 6. Add megacheck.check-unexported option: it found some issues in the repo, fixed them all
hi, |
You're my hero, dude. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
unparam
is one of the fewgometalinter
linters missing fromgolangci-lint
. It catches unused function parameters. I don't know if it's worthwhile. Maybe that functionality is already handled by another linter? I'd like to hear fromgolangci
about whether this is worth adding. Thanks!The text was updated successfully, but these errors were encountered: