Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLA which appears unused? #267

Closed
aneeshusa opened this issue Nov 2, 2018 · 3 comments
Closed

Remove CLA which appears unused? #267

aneeshusa opened this issue Nov 2, 2018 · 3 comments

Comments

@aneeshusa
Copy link
Contributor

I've started using golangci-lint and it's been really nice to use, thanks for making it!

I'm interested in contributing to golangci-lint for some projects at my workplace. We noticed that there is a CLA (https://github.com/golangci/golangci-lint/blob/f5f770165069eb1e70455ee42fbf51ab4ea4fea4/.github/CONTRIBUTING.md), but it doesn't seem to be enforced on pull requests.

My workplace requires a legal review of CLAs before approval of upstream repositories. In the spirit of #232, can you consider removing the CLA, or at least clarify if it is actually being used or not?

jirfag added a commit that referenced this issue Nov 4, 2018
@jirfag
Copy link
Contributor

jirfag commented Nov 4, 2018

hi!
thank you for noticing that the CLA isn't enforced. I've updated the CLA and made it required for pull requests via CLAassistant.

Please, notify is our CLA ok for your company's legal department.

@aneeshusa
Copy link
Contributor Author

Thanks for clarifying the status of the CLA, I will close this issue.
I'll start the legal review process at my workplace and open a new issue if it uncovers any concerns.

@oliverpool
Copy link

I think that CLAs which grants an unlimited license are harmful to open source.

I would recommend using a Developer Certificate of Origin (DCO), like the Linux kernel does.

https://drewdevault.com/2023/07/04/Dont-sign-a-CLA-2.html

#4227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants