Skip to content

Do not store the binary in GOPATH/bin in the Docker image #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dirbaio opened this issue Nov 23, 2018 · 1 comment
Closed

Do not store the binary in GOPATH/bin in the Docker image #304

Dirbaio opened this issue Nov 23, 2018 · 1 comment

Comments

@Dirbaio
Copy link

Dirbaio commented Nov 23, 2018

Docker image version: golangci/golangci-lint:v1.12.2

For CI builds using Go 1.11 modules, it's common to cache the GOPATH between builds, so that dependencies are downloaded only once. This is usually done by mounting an external dir from the build host on top of /go.

The issue is that golangci-lint binary is in /go/bin/golangci-lint. If GOPATH is mounted from outside, the binary stops being visible in the filesystem, and is thus not possible to run it.

IMO it would be better if golangci-lint was stored in /usr/local/bin, so it's always accessible.

@tpounds
Copy link
Contributor

tpounds commented Oct 1, 2019

@Dirbaio Closing as it appears this was also reported in #393 and fixed by #396.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants