Skip to content

Docker image: would you consider moving the binary elsewhere? #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsouza opened this issue Feb 13, 2019 · 0 comments
Closed

Docker image: would you consider moving the binary elsewhere? #393

fsouza opened this issue Feb 13, 2019 · 0 comments

Comments

@fsouza
Copy link
Contributor

fsouza commented Feb 13, 2019

Using the Docker image in a Drone CI pipeline, I noticed that due to the binary being written to $GOPATH/bin, whenever using $GOPATH as the Drone workspace (to persist dependencies between steps), the binary becomes unavailable because Drone mounts $GOPATH as a volume.

One solution is to not use /go as the $GOPATH, but that would require either setting the environment variable in every step or customizing the images we use in every step. So the solution was to create a Docker image for golangci-lint that installs the binary to /bin/ instead of $GOPATH/bin. Would a PR with that change be accepted? :)

Some links:

@fsouza fsouza changed the title Docker image: would you consider moving the binary elsewhere Docker image: would you consider moving the binary elsewhere? Feb 13, 2019
@jirfag jirfag closed this as completed in f7d2e92 Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants