-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing config allow-leading-space for nolintlint #3063
Comments
Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors. |
Same here. I use this configuration
however |
Hello, Due to a change of So the option The syntax of directives is: If you do that your IDE (ex: goland) will format the directive as a directive and it will not add extra space. Related to: |
@ldez can you please update the documentation if this setting has been removed? https://golangci-lint.run/usage/linters/#nolintlint |
Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Some of the updated linters require go 1.19 so this commit updates the github workflow to use go 1.19 for the "check" section. Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Some of the updated linters require go 1.19 so this commit updates the github workflow to use go 1.19 for the "check" section. Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Fixes vmware-tanzu#240 Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Fixes vmware-tanzu#240 Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Some of the updated linters require go 1.19 so this commit updates the github workflow to use go 1.19 for the "check" section. Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <[email protected]>
Ref. - golangci/golangci-lint#3063 - https://golangci-lint.run/usage/linters/#revive Signed-off-by: Damien Duportal <[email protected]>
Ref. - golangci/golangci-lint#3063 - https://golangci-lint.run/usage/linters/#revive Signed-off-by: Damien Duportal <[email protected]>
- Use double instead of single quotes - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
Note: You can use `golangci-lint config verify` to check if the `.golangci.yml` config matches the published schema. - `tenv` has been deprecated in favour of `usetesting` - `allow-leading-space` has been removed from `nolintlint`: golangci/golangci-lint#3063 - `revive` doesn't have `error-code` `warning-code` as config options (see https://golangci-lint.run/usage/linters/#revive). There's some discussion mgechev/revive#241 about adding `set_exit_status` to `revive`, but it's not exposed via `golangci-lint` Signed-off-by: Mihai Todor <[email protected]>
- Use double instead of single quotes - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
- Use double instead of single quotes - Replace the deprecated exportloopref with copyloopvar https://github.com/kyoh86/exportloopref https://golangci-lint.run/usage/linters/#exportloopref - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
- Use double instead of single quotes - Replace the deprecated exportloopref with copyloopvar https://github.com/kyoh86/exportloopref https://golangci-lint.run/usage/linters/#exportloopref - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
- Replace the deprecated exportloopref with copyloopvar https://github.com/kyoh86/exportloopref https://golangci-lint.run/usage/linters/#exportloopref (No longer available) https://golangci-lint.run/usage/linters/#copyloopvar - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
- Replace the deprecated exportloopref with copyloopvar https://github.com/kyoh86/exportloopref https://golangci-lint.run/usage/linters/#exportloopref (No longer available) https://golangci-lint.run/usage/linters/#copyloopvar - mnd.checks is an array https://golangci-lint.run/usage/linters/#mnd - maligned is deprecated and no longer used https://golangci-lint.run/usage/configuration/#config-file - nolintlint.allow-leading-space was dropped some time ago golangci/golangci-lint#3063 Signed-off-by: Lee Yarwood <[email protected]>
Welcome
Description of the problem
the setting allow-leading-space for nolintlint is not part of the NoLintLint settings
Version of golangci-lint
Configuration file
$ cat .golangci.yml
Go environment
Verbose output of running
Code example or link to a public repository
// add your code here
The text was updated successfully, but these errors were encountered: