Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why HEAD~1 ? #460

Closed
Dieterbe opened this issue Mar 24, 2019 · 3 comments · Fixed by #5362
Closed

Why HEAD~1 ? #460

Dieterbe opened this issue Mar 24, 2019 · 3 comments · Fixed by #5362
Labels
enhancement New feature or improvement

Comments

@Dieterbe
Copy link

Hi,
I wholeheartedly agree on it being unrealistic to start addressing all existing issues, but rather prevent any new ones.
To that end, why --new-from-rev=HEAD~1 ? That would just show diffs introduced in the last commit only, no?
Many PR's are many more commits.
How about instead --new-from-rev=$(git merge-base master HEAD) ? Or if the PR branch is always properly based on master, could just use master ?

@Dieterbe Dieterbe changed the title Why HEAD~1 Why HEAD~1 ? Mar 24, 2019
@jirfag
Copy link
Contributor

jirfag commented Apr 20, 2019

Hi, thank you!
Looks like $(git merge-base master HEAD) is better. We can't set just origin/master because there are can be another merged branches in master, and they will be included in the current diff.

@stale
Copy link

stale bot commented Mar 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Mar 31, 2020
@stale stale bot closed this as completed Apr 14, 2020
@liuhao2050
Copy link

if current HEAD is origin/master, --new-from-rev=$(git merge-base master HEAD) seems won't work because there is nothing new.

@ldez ldez added enhancement New feature or improvement and removed area: docs stale No recent correspondence or work activity labels Jan 31, 2025
@ldez ldez reopened this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants