feat: add new issues.new-from-merge-base option #5362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
issues.new-from-merge-base
option.git merge-base
is a better approach than an explicit revision:When using
issues.new-from-rev=main
, the diff will be betweene
andg
, which is wrong.With
issues.new-from-merge-base=main
, the diff will be betweene
andb
, which is right.The new option uses
git merge-base <ref> HEAD
internally. (https://github.com/golangci/revgrep/blob/43995b04fc9795de8791e8a9d82206f95d8acaf1/patch.go#L182)Reference: https://git-scm.com/docs/git-merge-base
Some real-life examples:
Fixes #460