Skip to content

Adding -D when also passing config file ignores config? #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srenatus opened this issue Jun 4, 2018 · 5 comments
Closed

Adding -D when also passing config file ignores config? #66

srenatus opened this issue Jun 4, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@srenatus
Copy link
Contributor

srenatus commented Jun 4, 2018

With a .golangci.toml containing

[linters]
enable-all = true
disable = [
  "dupl",
  "goconst",
  "maligned",
  "golint"
]

and running golangci-lint run -c ../../.golangci.toml -Dtypecheck ./... to also disable typecheck, the previously disabled linters are enabled again.
golangci pushed a commit that referenced this issue Jun 5, 2018
@jirfag
#66: properly merge (not overwrite) slice flags from config and comma…
671f168 
…nd-line
@jirfag
Copy link
Contributor

jirfag commented Jun 5, 2018

hi, thank you for the issue!
I have a fix in the linked commit, but it needs more testing

golangci pushed a commit that referenced this issue Jun 6, 2018
@jirfag
#66: properly merge (not overwrite) slice flags from config and comma…
afc4b43 
…nd-line
jirfag added a commit that referenced this issue Jun 6, 2018
@jirfag
Merge pull request #69 from golangci/support/properly-merge-slice-fla…
58b4d28 
…gs-from-config-and-cmd

#66: properly merge (not overwrite) slice flags from config and comma…
@jirfag
Copy link
Contributor

jirfag commented Jun 6, 2018

check in master please

@jirfag jirfag added bug Something isn't working awaiting_for_check_by_author labels Jun 6, 2018
@srenatus
Copy link
Contributor Author

srenatus commented Jun 6, 2018

✔️ Thanks! Works fine.

@srenatus srenatus closed this as completed Jun 6, 2018
@srenatus
Copy link
Contributor Author

srenatus commented Jun 6, 2018

@jirfag do you think this might warrant a release? I'd love to fix some stuff in our repo, waiting for this bugfix.

@jirfag
Copy link
Contributor

jirfag commented Jun 6, 2018

I included this fix into v1.5 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srenatus @jirfag